feat: solana code-fence features in main cp-12.18.0 #32284

aganglada · 2025-04-25T12:00:22Z

Description

Moves code-fence solana features to main build

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-25T12:00:40Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…at/solana-in-main

…tension into feat/solana-in-main

metamaskbot · 2025-04-30T08:31:47Z

✨ Files requiring CODEOWNER review ✨

🪪 @MetaMask/identity

test/e2e/tests/identity/account-syncing/backup-and-sync-settings.spec.ts
test/e2e/tests/identity/account-syncing/importing-private-key-account.spec.ts
test/e2e/tests/identity/account-syncing/new-user-sync.spec.ts
test/e2e/tests/identity/account-syncing/onboarding-with-opt-out.spec.ts
test/e2e/tests/identity/account-syncing/sync-after-adding-account.spec.ts
test/e2e/tests/identity/account-syncing/sync-after-modifying-account-name.spec.ts
test/e2e/tests/identity/account-syncing/sync-after-onboarding.spec.ts
test/e2e/tests/identity/account-syncing/sync-with-account-balances.spec.ts

metamaskbot · 2025-04-30T09:31:44Z

❌ API Spec Test Failed. View the report here.

metamaskbot · 2025-05-01T13:35:44Z

Builds ready [4a2f23d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1196 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1196	1058	1425	67	1234	1308
			load	1039	916	1175	58	1088	1134
			domContentLoaded	1034	911	1164	57	1078	1132
			domInteractive	17	13	58	7	16	27
			firstPaint	661	100	1140	419	1047	1116
			backgroundConnect	6	4	17	2	7	9
			firstReactRender	22	15	51	7	22	40
			getState	14	5	37	8	19	33
			initialActions	0	0	1	0	0	1
			loadScripts	799	676	928	56	845	897
			setupStore	8	5	19	2	9	12
	Webpack	Home	uiStartup	2123	1605	2600	180	2247	2371
			load	1647	1277	2085	148	1742	1840
			domContentLoaded	1640	1273	2082	148	1738	1836
			domInteractive	16	11	55	9	13	44
			firstPaint	169	66	371	64	208	298
			backgroundConnect	31	10	352	37	32	72
			firstReactRender	188	54	375	118	312	356
			getState	14	4	312	31	14	26
			initialActions	6	1	272	27	3	5
			loadScripts	1635	1268	2080	148	1732	1835
			setupStore	19	6	247	24	20	34
Firefox	Browserify	Home	uiStartup	1364	1212	1639	102	1430	1577
			load	1216	1062	1510	106	1291	1419
			domContentLoaded	1216	1062	1510	106	1290	1419
			domInteractive	106	42	240	31	121	156
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	210	22	20	52
			firstReactRender	24	20	57	7	23	44
			getState	7	4	12	2	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1197	1044	1488	107	1276	1401
			setupStore	6	4	15	2	6	9
	Webpack	Home	uiStartup	1556	1341	2164	147	1621	1795
			load	1333	1173	1958	133	1383	1547
			domContentLoaded	1332	1173	1958	133	1383	1546
			domInteractive	84	56	232	33	88	157
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	14	303	29	24	47
			firstReactRender	37	30	55	6	41	50
			getState	11	5	45	8	10	31
			initialActions	1	0	2	1	1	1
			loadScripts	1310	1158	1940	126	1357	1522
			setupStore	11	5	295	29	8	24

Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 157 exceeds gate value 156 for firefox webpack home p95 domInteractive
Sum of mean exceeds: 1ms | Sum of p95 exceeds: 1ms
Sum of all benchmark exceeds: 2ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -632 Bytes (-0.01%)
ui: 44.89 KiB (0.64%)
common: 5.96 KiB (0.06%)

metamaskbot · 2025-05-01T20:47:04Z

Builds ready [1035655]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1221 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1221	1095	1458	71	1257	1348
			load	1059	948	1289	64	1091	1166
			domContentLoaded	1053	944	1284	64	1086	1161
			domInteractive	17	14	60	6	16	29
			firstPaint	724	82	1292	427	1082	1146
			backgroundConnect	7	4	22	3	7	11
			firstReactRender	22	15	51	7	22	38
			getState	14	6	41	8	19	32
			initialActions	0	0	5	1	0	1
			loadScripts	815	709	1049	62	851	916
			setupStore	8	5	15	2	8	12
	Webpack	Home	uiStartup	2101	1691	2587	202	2245	2473
			load	1617	1270	2069	170	1733	1935
			domContentLoaded	1611	1265	2065	168	1728	1913
			domInteractive	16	11	58	10	13	47
			firstPaint	166	63	310	57	209	281
			backgroundConnect	33	10	397	52	28	71
			firstReactRender	186	54	385	117	317	363
			getState	11	4	37	6	13	24
			initialActions	3	1	7	1	3	5
			loadScripts	1606	1258	2063	167	1727	1889
			setupStore	18	7	286	28	19	30
Firefox	Browserify	Home	uiStartup	1364	1178	1925	126	1409	1621
			load	1216	1008	1700	122	1281	1441
			domContentLoaded	1216	1008	1699	122	1281	1441
			domInteractive	109	38	531	57	114	166
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	132	20	20	83
			firstReactRender	23	19	50	4	23	29
			getState	9	4	179	17	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1195	997	1684	120	1257	1426
			setupStore	7	4	62	7	6	15
	Webpack	Home	uiStartup	1516	1341	1981	129	1603	1770
			load	1296	1166	1603	104	1373	1502
			domContentLoaded	1296	1165	1602	104	1373	1502
			domInteractive	82	41	164	24	91	144
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	58	7	23	37
			firstReactRender	36	29	97	7	37	43
			getState	11	4	38	7	10	31
			initialActions	0	0	1	0	1	1
			loadScripts	1277	1150	1586	103	1356	1477
			setupStore	15	4	395	46	8	34

Benchmark value 2474 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 83 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 2ms | Sum of p95 exceeds: 39ms
Sum of all benchmark exceeds: 41ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -632 Bytes (-0.01%)
ui: 44.89 KiB (0.64%)
common: 5.96 KiB (0.06%)

mathieuartu

Identity changes LGTM, summoning @cmd-ob for a second pair of eyes!

metamaskbot · 2025-05-02T08:18:00Z

Builds ready [dcbfd3f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1202 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1202	1099	1435	61	1247	1307
			load	1040	951	1235	53	1070	1124
			domContentLoaded	1035	946	1230	52	1066	1117
			domInteractive	17	13	60	6	16	27
			firstPaint	673	132	1166	412	1040	1120
			backgroundConnect	6	4	19	2	7	9
			firstReactRender	21	16	42	5	22	33
			getState	14	5	36	8	20	31
			initialActions	0	0	1	0	0	1
			loadScripts	795	707	984	50	824	877
			setupStore	8	5	22	3	8	13
	Webpack	Home	uiStartup	2136	1654	2534	152	2241	2371
			load	1655	1288	2081	120	1743	1822
			domContentLoaded	1650	1284	2077	120	1738	1816
			domInteractive	16	11	60	10	13	44
			firstPaint	174	64	336	57	217	292
			backgroundConnect	26	9	242	25	26	49
			firstReactRender	205	54	395	122	324	362
			getState	11	4	39	6	13	19
			initialActions	3	1	7	1	3	4
			loadScripts	1644	1280	2055	121	1736	1811
			setupStore	15	6	48	7	18	28
Firefox	Browserify	Home	uiStartup	1390	1197	1817	120	1457	1638
			load	1236	1040	1592	118	1318	1455
			domContentLoaded	1236	1040	1592	118	1317	1455
			domInteractive	100	36	176	25	118	140
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	74	9	22	38
			firstReactRender	24	20	46	5	25	34
			getState	8	4	36	4	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1218	1030	1559	116	1301	1437
			setupStore	11	4	205	28	7	17
	Webpack	Home	uiStartup	1531	1374	2018	124	1567	1778
			load	1310	1181	1755	109	1357	1516
			domContentLoaded	1309	1180	1755	109	1357	1516
			domInteractive	79	53	156	21	84	134
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	68	9	25	42
			firstReactRender	36	29	53	5	40	45
			getState	11	4	33	8	10	31
			initialActions	1	0	2	1	1	1
			loadScripts	1290	1162	1738	108	1340	1497
			setupStore	12	5	269	27	8	27

Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Sum of mean exceeds: 2ms | Sum of p95 exceeds: 0ms
Sum of all benchmark exceeds: 2ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -632 Bytes (-0.01%)
ui: 44.89 KiB (0.64%)
common: 5.96 KiB (0.06%)

metamaskbot · 2025-05-02T16:19:27Z

Builds ready [fadc1c9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1226 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1226	1097	1425	63	1259	1346
			load	1068	962	1218	60	1098	1188
			domContentLoaded	1062	953	1211	60	1093	1182
			domInteractive	16	13	30	4	16	29
			firstPaint	743	93	1206	424	1083	1176
			backgroundConnect	7	4	27	3	8	9
			firstReactRender	21	16	38	4	22	32
			getState	14	6	40	8	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	820	715	960	57	847	937
			setupStore	8	4	19	3	8	16
	Webpack	Home	uiStartup	2125	1731	2531	178	2237	2368
			load	1624	1308	2052	149	1721	1835
			domContentLoaded	1618	1303	2049	149	1716	1830
			domInteractive	16	11	51	10	13	44
			firstPaint	166	59	362	62	186	323
			backgroundConnect	34	10	392	52	36	64
			firstReactRender	192	55	370	113	314	360
			getState	11	5	38	6	12	23
			initialActions	3	1	8	1	3	5
			loadScripts	1613	1301	2026	148	1712	1826
			setupStore	17	7	43	8	20	35
Firefox	Browserify	Home	uiStartup	1384	1218	1671	96	1433	1569
			load	1230	1080	1504	96	1297	1387
			domContentLoaded	1229	1080	1503	96	1297	1387
			domInteractive	106	36	305	32	116	157
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	58	8	23	40
			firstReactRender	24	20	54	5	26	31
			getState	10	4	211	21	8	14
			initialActions	0	0	1	0	0	1
			loadScripts	1211	1042	1487	97	1280	1365
			setupStore	9	4	180	19	6	17
	Webpack	Home	uiStartup	1571	1378	2098	145	1641	1881
			load	1345	1186	1867	133	1425	1608
			domContentLoaded	1345	1186	1867	133	1425	1607
			domInteractive	78	38	145	18	86	122
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	63	8	24	38
			firstReactRender	37	29	57	6	39	50
			getState	9	5	43	6	10	21
			initialActions	1	0	2	1	1	1
			loadScripts	1325	1170	1852	133	1410	1583
			setupStore	11	5	323	31	8	13

Benchmark value 1063 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1182 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Sum of mean exceeds: 2ms | Sum of p95 exceeds: 2ms
Sum of all benchmark exceeds: 4ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -520 Bytes (-0.01%)
ui: 44.89 KiB (0.64%)
common: 5.96 KiB (0.06%)

metamaskbot · 2025-05-05T23:39:26Z

Builds ready [d41dee7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1195 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1195	1081	1404	60	1230	1319
			load	1044	949	1235	56	1078	1129
			domContentLoaded	1037	940	1231	57	1073	1125
			domInteractive	18	13	65	9	16	29
			firstPaint	711	78	1205	419	1066	1109
			backgroundConnect	8	3	81	9	7	10
			firstReactRender	19	16	29	3	20	24
			getState	15	5	58	9	20	32
			initialActions	0	0	1	0	0	1
			loadScripts	798	669	983	56	833	873
			setupStore	7	5	20	2	8	10
	Webpack	Home	uiStartup	2140	1633	2478	179	2297	2365
			load	1659	1264	1920	137	1754	1842
			domContentLoaded	1653	1260	1890	137	1747	1837
			domInteractive	15	11	58	9	13	43
			firstPaint	168	65	342	57	199	272
			backgroundConnect	27	9	227	23	31	52
			firstReactRender	160	53	430	101	268	343
			getState	19	4	385	45	14	28
			initialActions	3	1	8	1	3	6
			loadScripts	1648	1256	1865	138	1742	1832
			setupStore	23	6	364	41	21	46
Firefox	Browserify	Home	uiStartup	1402	1227	1920	131	1453	1685
			load	1244	1072	1667	114	1298	1527
			domContentLoaded	1244	1072	1667	114	1298	1527
			domInteractive	110	37	212	32	127	174
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	13	195	22	22	58
			firstReactRender	25	20	64	8	26	50
			getState	11	4	216	22	9	13
			initialActions	0	0	2	0	0	1
			loadScripts	1222	1049	1637	107	1273	1453
			setupStore	12	4	395	43	6	13
	Webpack	Home	uiStartup	1533	1353	2087	142	1571	1887
			load	1316	1180	1805	126	1366	1593
			domContentLoaded	1316	1179	1805	126	1365	1593
			domInteractive	78	44	162	19	85	118
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	83	9	22	41
			firstReactRender	35	29	52	6	37	48
			getState	9	5	32	4	9	19
			initialActions	0	0	1	0	1	1
			loadScripts	1297	1165	1785	125	1347	1569
			setupStore	11	5	281	28	8	24

Benchmark value 1244 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1685 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1527 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1527 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Sum of mean exceeds: 9ms | Sum of p95 exceeds: 89ms
Sum of all benchmark exceeds: 98ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -723 Bytes (-0.01%)
ui: 44.28 KiB (0.63%)
common: 5.95 KiB (0.06%)

metamaskbot · 2025-05-06T01:18:27Z

Builds ready [687ace1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1198 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1198	1078	1494	59	1230	1293
			load	1048	951	1294	53	1076	1155
			domContentLoaded	1043	947	1287	53	1070	1144
			domInteractive	16	13	30	4	16	28
			firstPaint	750	77	1166	405	1060	1130
			backgroundConnect	7	4	45	5	7	11
			firstReactRender	19	15	34	4	20	28
			getState	15	5	98	11	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	801	702	1036	51	827	909
			setupStore	7	5	18	2	7	10
	Webpack	Home	uiStartup	2132	1699	2553	170	2241	2392
			load	1648	1244	1999	144	1744	1884
			domContentLoaded	1642	1239	1974	143	1738	1879
			domInteractive	15	11	51	9	13	43
			firstPaint	172	61	427	71	214	290
			backgroundConnect	34	10	399	48	37	67
			firstReactRender	189	54	448	120	308	360
			getState	11	4	36	6	14	24
			initialActions	3	1	8	1	3	4
			loadScripts	1637	1237	1950	142	1735	1877
			setupStore	19	6	181	23	19	38
Firefox	Browserify	Home	uiStartup	1355	1194	1769	110	1384	1578
			load	1208	1062	1528	102	1252	1426
			domContentLoaded	1208	1061	1528	102	1252	1426
			domInteractive	104	41	315	34	113	167
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	71	8	20	27
			firstReactRender	23	19	53	5	22	28
			getState	7	4	22	2	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1191	1048	1508	100	1235	1409
			setupStore	8	4	169	17	6	10
	Webpack	Home	uiStartup	1525	1345	2168	133	1591	1772
			load	1312	1166	1899	122	1377	1509
			domContentLoaded	1311	1166	1898	122	1377	1509
			domInteractive	77	50	148	18	83	116
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	15	286	27	23	41
			firstReactRender	35	29	50	5	37	45
			getState	9	4	46	7	9	29
			initialActions	0	0	2	1	1	1
			loadScripts	1290	1151	1861	112	1355	1490
			setupStore	8	5	35	5	8	20

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -723 Bytes (-0.01%)
ui: 44.28 KiB (0.63%)
common: 5.95 KiB (0.06%)

metamaskbot · 2025-05-06T07:31:15Z

Builds ready [d93c623]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1233 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1233	1101	1406	62	1276	1351
			load	1071	942	1221	54	1108	1151
			domContentLoaded	1065	938	1217	54	1103	1142
			domInteractive	18	13	77	10	17	32
			firstPaint	720	152	1170	428	1099	1147
			backgroundConnect	7	4	22	3	7	13
			firstReactRender	21	16	65	6	21	30
			getState	13	6	44	7	18	27
			initialActions	0	0	1	0	0	1
			loadScripts	823	710	974	53	859	901
			setupStore	8	5	22	2	8	13
	Webpack	Home	uiStartup	2128	1715	2573	183	2275	2380
			load	1655	1244	1988	144	1754	1861
			domContentLoaded	1650	1240	1978	144	1746	1852
			domInteractive	15	11	62	10	13	44
			firstPaint	172	68	368	60	191	310
			backgroundConnect	25	9	234	24	27	50
			firstReactRender	162	54	468	108	286	352
			getState	11	4	54	7	12	24
			initialActions	3	1	6	1	3	5
			loadScripts	1645	1237	1954	145	1743	1849
			setupStore	25	7	382	50	20	45
Firefox	Browserify	Home	uiStartup	1369	1198	1766	122	1426	1627
			load	1219	1068	1573	108	1294	1426
			domContentLoaded	1219	1068	1572	108	1293	1426
			domInteractive	108	37	272	43	120	204
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	174	17	20	31
			firstReactRender	23	19	73	6	22	29
			getState	12	4	241	30	8	30
			initialActions	0	0	1	0	0	1
			loadScripts	1201	1054	1476	104	1281	1406
			setupStore	6	4	24	3	6	11
	Webpack	Home	uiStartup	1583	1362	2275	173	1658	2011
			load	1364	1182	1803	145	1467	1716
			domContentLoaded	1363	1182	1802	145	1466	1716
			domInteractive	78	35	150	20	81	129
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	65	8	24	44
			firstReactRender	35	29	51	5	37	45
			getState	12	4	338	33	9	21
			initialActions	0	0	2	1	1	1
			loadScripts	1344	1168	1787	144	1450	1693
			setupStore	11	5	358	35	8	14

cc: @HowardBraham
Benchmark value 1072 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1066 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 204 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 30 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 2011 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1716 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1716 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1693 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 9ms | Sum of p95 exceeds: 266ms
Sum of all benchmark exceeds: 275ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -7.06 KiB (-0.13%)
ui: 56.92 KiB (0.81%)
common: -5.94 KiB (-0.06%)

metamaskbot · 2025-05-06T08:40:08Z

❌ API Spec Test Failed. View the report here.

## **Description**  [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32545?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-05-06T11:18:40Z

Builds ready [8eee84a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1264 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1264	1130	1455	67	1303	1393
			load	1095	933	1276	68	1134	1232
			domContentLoaded	1088	927	1264	68	1127	1224
			domInteractive	19	13	67	8	19	35
			firstPaint	646	96	1273	451	1097	1229
			backgroundConnect	8	4	30	4	8	16
			firstReactRender	21	16	56	6	20	34
			getState	15	6	39	7	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	839	684	1026	66	874	975
			setupStore	8	5	24	3	8	16
	Webpack	Home	uiStartup	2152	1642	2537	192	2302	2442
			load	1689	1297	2172	165	1777	1971
			domContentLoaded	1683	1291	2168	165	1772	1940
			domInteractive	15	11	60	11	13	49
			firstPaint	172	62	343	62	193	309
			backgroundConnect	31	10	250	35	33	74
			firstReactRender	156	54	377	104	276	350
			getState	14	4	225	23	15	35
			initialActions	3	1	6	1	3	4
			loadScripts	1678	1289	2167	166	1769	1917
			setupStore	15	6	42	7	19	33
Firefox	Browserify	Home	uiStartup	1353	1179	1677	117	1418	1615
			load	1201	1034	1490	100	1260	1393
			domContentLoaded	1201	1034	1490	100	1260	1392
			domInteractive	97	35	256	29	108	139
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	123	13	22	47
			firstReactRender	23	19	50	5	22	31
			getState	10	4	231	23	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1182	1021	1467	98	1246	1373
			setupStore	10	4	206	28	6	12
	Webpack	Home	uiStartup	1624	1428	2254	168	1728	2001
			load	1398	1229	1945	147	1513	1759
			domContentLoaded	1398	1229	1945	147	1512	1759
			domInteractive	85	35	318	37	89	122
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	16	101	13	25	43
			firstReactRender	36	29	52	5	38	46
			getState	13	5	360	35	10	30
			initialActions	0	0	2	1	1	1
			loadScripts	1376	1208	1925	148	1491	1734
			setupStore	8	5	31	3	9	11

cc: @HowardBraham
Benchmark value 1264 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1096 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1089 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 840 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1394 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1232 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1225 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1230 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 975 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1624 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1398 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1398 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 1376 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2001 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1759 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1759 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1734 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 157ms | Sum of p95 exceeds: 569ms
Sum of all benchmark exceeds: 726ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -520 Bytes (-0.01%)
ui: 44.89 KiB (0.64%)
common: 5.96 KiB (0.06%)

feat: solana code-fence features in main

d038153

aganglada self-assigned this Apr 25, 2025

metamaskbot added the team-new-networks PRs from the New Networks team label Apr 25, 2025

aganglada changed the title ~~feat: solana code-fence features in main~~ feat: solana code-fence features in main cp-12.18.0 Apr 25, 2025

javiergarciavera and others added 8 commits April 25, 2025 14:04

feat: moved Solana tests to regular build for release

b628e50

feat: added FF for createSolanaaCcount

6edd3e6

Merge branch 'main' of github.com:MetaMask/metamask-extension into fe…

8661a70

…at/solana-in-main

feat: fixed state for solana

0724471

fix: fix carousel tests

49298be

feat: fix conflicts

eba77ac

fix: add account type filtering filtering for accout sync tests

ba20f62

Merge branch 'feat/solana-in-main' of github.com:MetaMask/metamask-ex…

75978eb

…tension into feat/solana-in-main

cmd-ob requested a review from a team as a code owner April 30, 2025 08:27

javiergarciavera added 2 commits April 30, 2025 10:49

feat: update import path

8435255

feat: fix lint

408b381

javiergarciavera and others added 2 commits April 30, 2025 12:22

feat: missing file

82c31c0

Merge branch 'main' into feat/solana-in-main

4a2f23d

Merge branch 'main' into feat/solana-in-main

1035655

Merge branch 'main' into feat/solana-in-main

dcbfd3f

mathieuartu previously approved these changes May 2, 2025

View reviewed changes

Merge branch 'main' into feat/solana-in-main

fadc1c9

javiergarciavera previously approved these changes May 2, 2025

View reviewed changes

fix: fixing some flakiness on testHelpers file

36dd910

delay

687ace1

feat: reduced timeout to speed up tests

d93c623

javiergarciavera added 3 commits May 6, 2025 10:03

feat: increased timeout

879cfda

feat: added no custom network client found

874ce30

feat: fixed more flakiness

a27dd60

seaona and others added 4 commits May 6, 2025 11:31

Merge branch 'main' into feat/solana-in-main

be10296

feat: added message

41abbe9

feat: lint

951ef91

javiergarciavera added the skip-e2e-quality-gate label May 6, 2025

fix: skip multichain test case

8eee84a

racitores approved these changes May 6, 2025

View reviewed changes

cmd-ob approved these changes May 6, 2025

View reviewed changes

javiergarciavera added this pull request to the merge queue May 6, 2025

ulissesferreira approved these changes May 6, 2025

View reviewed changes

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2025

aganglada added this pull request to the merge queue May 6, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2025

javiergarciavera added this pull request to the merge queue May 6, 2025

Merged via the queue into main with commit 2a4f5ab May 6, 2025
163 checks passed

javiergarciavera deleted the feat/solana-in-main branch May 6, 2025 16:41

github-actions bot locked and limited conversation to collaborators May 6, 2025

baptiste-marchand restored the feat/solana-in-main branch May 16, 2025 14:15

baptiste-marchand deleted the feat/solana-in-main branch June 25, 2025 09:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: solana code-fence features in main cp-12.18.0 #32284

feat: solana code-fence features in main cp-12.18.0 #32284

aganglada commented Apr 25, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

metamaskbot commented Apr 30, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Apr 30, 2025

Uh oh!

metamaskbot commented May 1, 2025

Uh oh!

metamaskbot commented May 1, 2025

Uh oh!

mathieuartu left a comment

Uh oh!

metamaskbot commented May 2, 2025

Uh oh!

metamaskbot commented May 2, 2025

Uh oh!

metamaskbot commented May 5, 2025

Uh oh!

metamaskbot commented May 6, 2025

Uh oh!

metamaskbot commented May 6, 2025

Uh oh!

metamaskbot commented May 6, 2025

Uh oh!

metamaskbot commented May 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: solana code-fence features in main cp-12.18.0 #32284

feat: solana code-fence features in main cp-12.18.0 #32284

Conversation

aganglada commented Apr 25, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

metamaskbot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Apr 30, 2025

Uh oh!

metamaskbot commented May 1, 2025

Uh oh!

metamaskbot commented May 1, 2025

Uh oh!

mathieuartu left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented May 2, 2025

Uh oh!

metamaskbot commented May 2, 2025

Uh oh!

metamaskbot commented May 5, 2025

Uh oh!

metamaskbot commented May 6, 2025

Uh oh!

metamaskbot commented May 6, 2025

Uh oh!

metamaskbot commented May 6, 2025

Uh oh!

metamaskbot commented May 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aganglada commented Apr 25, 2025 •

edited by github-actions bot

Loading

metamaskbot commented Apr 30, 2025 •

edited

Loading