Adding missing modal overlay to signature request original warning

[georgewrmarshall]

Description

In a previous PR, I unintentionally left out a commit from my local setup that added a modal overlay to the SignatureRequestOriginalWarning modal. The before/after videos I used were from my local setup, which mistakenly suggested that the modal overlay was included in the PR. This current PR rectifies that oversight by including the ModalOverlay, thereby resolving the missing overlay issue for the modal.

Related issues

Related: #22171

Manual testing steps

To check modal overlay in storybook

1. Go to the storybook build of this PR
2. Search SignatureRequestOriginalWarning in the search bar
3. See that the ModalOverlay is included compared to develop build of storybook

To check modal overlay works in app

1. Enable eth sign from settings
2. Go to test dapp
3. Trigger Eth Sign
4. Accept
5. See SignatureRequestOriginalWarning modal

Screenshots/Recordings

Before

Storybook showing no modal overlay

before.mov

In app showing modal overlay missing

before.app.mov

After

Storybook showing modal overlay

after.mov

In app showing modal overlay

after.app.mov

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd34bc5) 68.27% compared to head (cb3c22d) 68.27%.
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #22756   +/-   ##
========================================
  Coverage    68.27%   68.27%           
========================================
  Files         1087     1087           
  Lines        42770    42770           
  Branches     11371    11371           
========================================
  Hits         29201    29201           
  Misses       13569    13569           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [cb3c22d]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (755 ± 19 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	160	110	16	8
		domContentLoaded	10	26	16	4	2
		load	706	872	755	39	19
		domInteractive	10	26	16	4	2

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 45 Bytes (0.00%)
• common: 0 Bytes (0.00%)