Skip to content

Conversation

@hjetpoluru
Copy link
Contributor

Description

Fixing flaky test "Check if user select different type of secret recovery phrase" modified the dropdown to specifically select the element related to the secret recovery phrase, distinguishing it from another dropdown used for language selection. Additionally, updated the method to find elements by using a CSS selector for option selection.

Related issues

#22714

@hjetpoluru hjetpoluru added team-extension-platform Extension Platform team INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. flaky tests labels Jan 30, 2024
@hjetpoluru hjetpoluru self-assigned this Jan 30, 2024
@hjetpoluru hjetpoluru requested a review from a team as a code owner January 30, 2024 13:02
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 30, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [343e89f]
Page Load Metrics (765 ± 20 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8812310694
domContentLoaded9231542
load7028517654320
domInteractive9231542
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8317671) 68.08% compared to head (343e89f) 68.08%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22727   +/-   ##
========================================
  Coverage    68.08%   68.08%           
========================================
  Files         1091     1091           
  Lines        42923    42923           
  Branches     11415    11415           
========================================
  Hits         29223    29223           
  Misses       13700    13700           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjetpoluru hjetpoluru merged commit 3ff646b into develop Jan 30, 2024
@hjetpoluru hjetpoluru deleted the e2e/fix-flaky-test-22714-new branch January 30, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

flaky tests INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. INVALID-PR-TEMPLATE PR's body doesn't match template release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants