-
Notifications
You must be signed in to change notification settings - Fork 5.4k
UX: Updated Custom network displayed for selectable in network selection #22693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22693 +/- ##
===========================================
- Coverage 68.13% 68.12% -0.00%
===========================================
Files 1087 1087
Lines 42665 42681 +16
Branches 11349 11354 +5
===========================================
+ Hits 29066 29075 +9
- Misses 13599 13606 +7 ☔ View full report in Codecov by Sentry. |
Builds ready [c580da4]
Page Load Metrics (869 ± 60 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works wonderfully. We should move some code to selectors but can be done in a follow up!
This PR is to make sure if two networks with same id but different rpcUrl are there, list should show both of them
Related issues
Fixes: #22559
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist