[Bug|Feat] blockaid external link clicked metric update #22631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3 tasks
- getBlockaidMetricsParams - add external_link_clicked - return result type for all types - return reason for all types - clean uiCustomizations - let -> const - update "NotApplicable" type logic. should not change final result. test updated based on guardrails
- fix early return - no early return on fail type and allow resultType and reason to be added to params with it
…xternalLinkClicked
- need to wrap with Provider
Builds ready [c25c418]
Page Load Metrics (779 ± 40 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
digiwand
added
team-confirmations-secure-ux-PR
digiwand
added a commit
to MetaMask/core
that referenced
this pull request
Jan 25, 2024
## Explanation This prop is used to pass a value used to be added as a transaction metametric fragment prop. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? For example: --> Fixes https://github.com/MetaMask/MetaMask-planning/issues/1756 Related to MetaMask/metamask-extension#22631 ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/transaction-controller` - **feat**: Adds `externalLinkClicked` prop to TransactionMetaBase type ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
…ntFragment - updates updateTransactionEventFragment to allow tx.id
This reverts commit 132dd80.
digiwand
added a commit
to MetaMask/core
that referenced
this pull request
Jan 26, 2024
…3854) Reverts #3828 no longer needed after discovering we can update the event fragment ad-hoc using the useTransactionEventFragment hook Related to MetaMask/metamask-extension#22631
- pass transaction rather than pass securityAlertResponse for ease of use
…lockaidBannerAlert test phrase
digiwand
commented
Jan 27, 2024
| security_alert_reason: BlockaidReason.setApprovalForAll, | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
A few tests were added here from the original. The filepath name change triggered GH to read this as a brand new file rather than a mere file path change. to see previous changes refer to https://github.com/MetaMask/metamask-extension/pull/22631/files#diff-2170a0c1976571856c2f505ee2b08d977d41c03ab57afc38c350753ee4fd8684
Builds ready [48d8739]
Page Load Metrics (995 ± 70 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22631 +/- ##
===========================================
+ Coverage 68.11% 68.14% +0.02%
===========================================
Files 1086 1086
Lines 42628 42614 -14
Branches 11340 11337 -3
===========================================
+ Hits 29035 29036 +1
+ Misses 13593 13578 -15 ☔ View full report in Codecov by Sentry. |
jpuri
approved these changes
Jan 30, 2024
digiwand
changed the title
segun
approved these changes
Jan 31, 2024
digiwand
deleted the
feat-blockaid-external-link-clicked-metric-update
branch
metamaskbot
added
the
release-11.11.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various updates related to Blockaid metrics
Fixes
security_alert_responseandsecurity_alert_reasontransaction, event fragment prop if unnecessary. Previously would add "not applicable" values to all transaction metrics.Feat
security_alert_failedui_customization metric propCleanup
let uiCustomizations→const uiCustomizations = [];Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1756
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist