fix: Trezor connect - update to v9 in trezor-usb-permissions #22591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
external-contributor
INVALID-PR-TEMPLATE
|
I have read the CLA Document and I hereby sign the CLA |
|
Rerunning failed tests here and trying to get a passing / mergeable check. |
brad-decker
approved these changes
Jan 18, 2024
legobeat
approved these changes
Jan 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22591 +/- ##
===========================================
- Coverage 68.15% 68.15% -0.00%
===========================================
Files 1086 1086
Lines 42604 42604
Branches 11340 11340
===========================================
- Hits 29034 29033 -1
- Misses 13570 13571 +1 ☔ View full report in Codecov by Sentry. |
angelcheung22
added
the
team-hardware-wallets-deprecated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We found some issues at Trezor with the Metamask integration, one of them related to the USB permissions page being linked to a deprecated version of our SDK.
Metamask already uses the v9 package, but in this particular instance it's hardcoded to load from v5.
We added a workaround on our side for now, by adding a redirect.
This PR solves the problem properly by updating the version in the code.
Related issues
Unknown
Manual testing steps
NA
Screenshots/Recordings
NA