Skip to content

Commit 9c50ce2

Browse files
authored
fix: update to transaction-controller 28.1.1 to fix NFT mint simulation (#24306)
## **Description** Update transaction-controller core package to bring in this fix to NFT mint simulation: MetaMask/core#4217 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24306?quickstart=1) ## **Related issues** Fixes: #24251 ## **Manual testing steps** 1. Visit https://www.fxhash.xyz/generative/slug/g-l-y-p-h 2. Try minting the nft 3. Simulation should work and show the nft in the "You receive" section. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** (Simulation Failed message) ### **After** ![image](https://github.com/MetaMask/metamask-extension/assets/507015/ded0173a-088c-4f12-b3b6-09b823db7756) ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 8a0e455 commit 9c50ce2

File tree

5 files changed

+19
-16
lines changed

5 files changed

+19
-16
lines changed

app/scripts/lib/setupSentry.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ export const SENTRY_BACKGROUND_STATE = {
136136
gasEstimateType: true,
137137
gasFeeEstimates: true,
138138
gasFeeEstimatesByChainId: true,
139+
nonRPCGasFeeApisDisabled: false,
139140
},
140141
KeyringController: {
141142
isUnlocked: true,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@
326326
"@metamask/snaps-rpc-methods": "^8.0.0",
327327
"@metamask/snaps-sdk": "^4.0.1",
328328
"@metamask/snaps-utils": "^7.1.1",
329-
"@metamask/transaction-controller": "^28.1.0",
329+
"@metamask/transaction-controller": "^28.1.1",
330330
"@metamask/user-operation-controller": "^8.0.1",
331331
"@metamask/utils": "^8.2.1",
332332
"@ngraveio/bc-ur": "^1.1.12",

test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-background-state.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@
8181
"gasFeeEstimatesByChainId": {},
8282
"gasFeeEstimates": {},
8383
"estimatedGasFeeTimeBounds": {},
84-
"gasEstimateType": "none"
84+
"gasEstimateType": "none",
85+
"nonRPCGasFeeApisDisabled": "boolean"
8586
},
8687
"KeyringController": {
8788
"isUnlocked": false,
@@ -146,6 +147,7 @@
146147
"dismissSeedBackUpReminder": true,
147148
"disabledRpcMethodPreferences": { "eth_sign": false },
148149
"useMultiAccountBalanceChecker": true,
150+
"hasDismissedOpenSeaToBlockaidBanner": false,
149151
"useSafeChainsListValidation": "boolean",
150152
"useTokenDetection": false,
151153
"useNftDetection": false,
@@ -157,7 +159,6 @@
157159
"addSnapAccountEnabled": "boolean",
158160
"advancedGasFee": {},
159161
"featureFlags": {},
160-
"hasDismissedOpenSeaToBlockaidBanner": false,
161162
"incomingTransactionsPreferences": {},
162163
"knownMethodData": "object",
163164
"currentLocale": "en",

test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-ui-state.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
"isUnlocked": false,
1515
"isAccountMenuOpen": false,
1616
"isNetworkMenuOpen": false,
17-
"identities": "object",
1817
"internalAccounts": { "accounts": "object", "selectedAccount": "string" },
1918
"transactions": "object",
2019
"networkConfigurations": "object",
@@ -75,7 +74,6 @@
7574
"showAccountBanner": true,
7675
"trezorModel": null,
7776
"hadAdvancedGasFeesSetPriorToMigration92_3": false,
78-
"hasDismissedOpenSeaToBlockaidBanner": false,
7977
"nftsDropdownState": {},
8078
"termsOfUseLastAgreed": "number",
8179
"qrHardware": {},
@@ -103,6 +101,7 @@
103101
"dismissSeedBackUpReminder": true,
104102
"disabledRpcMethodPreferences": { "eth_sign": false },
105103
"useMultiAccountBalanceChecker": true,
104+
"hasDismissedOpenSeaToBlockaidBanner": false,
106105
"useSafeChainsListValidation": true,
107106
"useTokenDetection": false,
108107
"useNftDetection": false,
@@ -113,6 +112,7 @@
113112
"addSnapAccountEnabled": "boolean",
114113
"advancedGasFee": {},
115114
"incomingTransactionsPreferences": {},
115+
"identities": "object",
116116
"lostIdentities": "object",
117117
"forgottenPassword": false,
118118
"ipfsGateway": "string",
@@ -149,6 +149,7 @@
149149
"gasFeeEstimates": {},
150150
"estimatedGasFeeTimeBounds": {},
151151
"gasEstimateType": "none",
152+
"nonRPCGasFeeApisDisabled": "boolean",
152153
"tokenList": "object",
153154
"tokensChainsCache": {},
154155
"preventPollingOnNetworkRestart": false,

yarn.lock

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5324,12 +5324,12 @@ __metadata:
53245324
languageName: node
53255325
linkType: hard
53265326

5327-
"@metamask/gas-fee-controller@npm:^15.0.0":
5328-
version: 15.0.0
5329-
resolution: "@metamask/gas-fee-controller@npm:15.0.0"
5327+
"@metamask/gas-fee-controller@npm:^15.0.0, @metamask/gas-fee-controller@npm:^15.1.0":
5328+
version: 15.1.0
5329+
resolution: "@metamask/gas-fee-controller@npm:15.1.0"
53305330
dependencies:
53315331
"@metamask/base-controller": "npm:^5.0.1"
5332-
"@metamask/controller-utils": "npm:^9.0.2"
5332+
"@metamask/controller-utils": "npm:^9.1.0"
53335333
"@metamask/eth-query": "npm:^4.0.0"
53345334
"@metamask/ethjs-unit": "npm:^0.3.0"
53355335
"@metamask/network-controller": "npm:^18.1.0"
@@ -5341,7 +5341,7 @@ __metadata:
53415341
uuid: "npm:^8.3.2"
53425342
peerDependencies:
53435343
"@metamask/network-controller": ^18.0.0
5344-
checksum: f4ca2ca113d543d3f1282df8e171d06a8cd2ce99ad7df54d1796416f9c93dd62d998af09c124fbd5138b4592602c958d30c9fe03a8ed06ccaecd8745cd6a3913
5344+
checksum: 42e3dc470b9e075c2eff48f9272c5f0cc4f0a3357873b74301c928c227344ff670756d748fca95ae395dbedb72ce848cb6812fb07eb636410cd4db22c35f2060
53455345
languageName: node
53465346
linkType: hard
53475347

@@ -6425,9 +6425,9 @@ __metadata:
64256425
languageName: node
64266426
linkType: hard
64276427

6428-
"@metamask/transaction-controller@npm:^28.1.0":
6429-
version: 28.1.0
6430-
resolution: "@metamask/transaction-controller@npm:28.1.0"
6428+
"@metamask/transaction-controller@npm:^28.1.0, @metamask/transaction-controller@npm:^28.1.1":
6429+
version: 28.1.1
6430+
resolution: "@metamask/transaction-controller@npm:28.1.1"
64316431
dependencies:
64326432
"@ethereumjs/common": "npm:^3.2.0"
64336433
"@ethereumjs/tx": "npm:^4.2.0"
@@ -6439,7 +6439,7 @@ __metadata:
64396439
"@metamask/base-controller": "npm:^5.0.1"
64406440
"@metamask/controller-utils": "npm:^9.1.0"
64416441
"@metamask/eth-query": "npm:^4.0.0"
6442-
"@metamask/gas-fee-controller": "npm:^15.0.0"
6442+
"@metamask/gas-fee-controller": "npm:^15.1.0"
64436443
"@metamask/metamask-eth-abis": "npm:^3.1.1"
64446444
"@metamask/network-controller": "npm:^18.1.0"
64456445
"@metamask/rpc-errors": "npm:^6.2.1"
@@ -6456,7 +6456,7 @@ __metadata:
64566456
"@metamask/approval-controller": ^6.0.0
64576457
"@metamask/gas-fee-controller": ^15.0.0
64586458
"@metamask/network-controller": ^18.0.0
6459-
checksum: e043b74ba17ccf702226bf7bad4bd251d35485fc7d90da2108a5d188a0016bd1ed65a4b63e29c6395161c02964ac36936493d8cee43bfad147132fca17344df3
6459+
checksum: 01e6f0e1431e56cc0ef986cbfa99cf37e0a44aade14419c69d815be77847bb33b43049b90c6e6961bb5070ecfe1420c893db8a68c0fd6977d5ec28d9853d6554
64606460
languageName: node
64616461
linkType: hard
64626462

@@ -25555,7 +25555,7 @@ __metadata:
2555525555
"@metamask/snaps-utils": "npm:^7.1.1"
2555625556
"@metamask/test-bundler": "npm:^1.0.0"
2555725557
"@metamask/test-dapp": "npm:^8.4.0"
25558-
"@metamask/transaction-controller": "npm:^28.1.0"
25558+
"@metamask/transaction-controller": "npm:^28.1.1"
2555925559
"@metamask/user-operation-controller": "npm:^8.0.1"
2556025560
"@metamask/utils": "npm:^8.2.1"
2556125561
"@ngraveio/bc-ur": "npm:^1.1.12"

0 commit comments

Comments
 (0)