Commit 9c50ce2
authored
fix: update to transaction-controller 28.1.1 to fix NFT mint simulation (#24306)
## **Description**
Update transaction-controller core package to bring in this fix to NFT
mint simulation: MetaMask/core#4217
[](https://codespaces.new/MetaMask/metamask-extension/pull/24306?quickstart=1)
## **Related issues**
Fixes: #24251
## **Manual testing steps**
1. Visit https://www.fxhash.xyz/generative/slug/g-l-y-p-h
2. Try minting the nft
3. Simulation should work and show the nft in the "You receive" section.
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
(Simulation Failed message)
### **After**

## **Pre-merge author checklist**
- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.1 parent 8a0e455 commit 9c50ce2
File tree
5 files changed
+19
-16
lines changed- app/scripts/lib
- test/e2e/tests/metrics/state-snapshots
5 files changed
+19
-16
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| 139 | + | |
139 | 140 | | |
140 | 141 | | |
141 | 142 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
326 | 326 | | |
327 | 327 | | |
328 | 328 | | |
329 | | - | |
| 329 | + | |
330 | 330 | | |
331 | 331 | | |
332 | 332 | | |
| |||
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
| 85 | + | |
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
| |||
146 | 147 | | |
147 | 148 | | |
148 | 149 | | |
| 150 | + | |
149 | 151 | | |
150 | 152 | | |
151 | 153 | | |
| |||
157 | 159 | | |
158 | 160 | | |
159 | 161 | | |
160 | | - | |
161 | 162 | | |
162 | 163 | | |
163 | 164 | | |
| |||
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | 17 | | |
19 | 18 | | |
20 | 19 | | |
| |||
75 | 74 | | |
76 | 75 | | |
77 | 76 | | |
78 | | - | |
79 | 77 | | |
80 | 78 | | |
81 | 79 | | |
| |||
103 | 101 | | |
104 | 102 | | |
105 | 103 | | |
| 104 | + | |
106 | 105 | | |
107 | 106 | | |
108 | 107 | | |
| |||
113 | 112 | | |
114 | 113 | | |
115 | 114 | | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| 152 | + | |
152 | 153 | | |
153 | 154 | | |
154 | 155 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5324 | 5324 | | |
5325 | 5325 | | |
5326 | 5326 | | |
5327 | | - | |
5328 | | - | |
5329 | | - | |
| 5327 | + | |
| 5328 | + | |
| 5329 | + | |
5330 | 5330 | | |
5331 | 5331 | | |
5332 | | - | |
| 5332 | + | |
5333 | 5333 | | |
5334 | 5334 | | |
5335 | 5335 | | |
| |||
5341 | 5341 | | |
5342 | 5342 | | |
5343 | 5343 | | |
5344 | | - | |
| 5344 | + | |
5345 | 5345 | | |
5346 | 5346 | | |
5347 | 5347 | | |
| |||
6425 | 6425 | | |
6426 | 6426 | | |
6427 | 6427 | | |
6428 | | - | |
6429 | | - | |
6430 | | - | |
| 6428 | + | |
| 6429 | + | |
| 6430 | + | |
6431 | 6431 | | |
6432 | 6432 | | |
6433 | 6433 | | |
| |||
6439 | 6439 | | |
6440 | 6440 | | |
6441 | 6441 | | |
6442 | | - | |
| 6442 | + | |
6443 | 6443 | | |
6444 | 6444 | | |
6445 | 6445 | | |
| |||
6456 | 6456 | | |
6457 | 6457 | | |
6458 | 6458 | | |
6459 | | - | |
| 6459 | + | |
6460 | 6460 | | |
6461 | 6461 | | |
6462 | 6462 | | |
| |||
25555 | 25555 | | |
25556 | 25556 | | |
25557 | 25557 | | |
25558 | | - | |
| 25558 | + | |
25559 | 25559 | | |
25560 | 25560 | | |
25561 | 25561 | | |
| |||
0 commit comments