Skip to content

Commit 8a0e455

Browse files
ccharlygantunesr
andauthored
fix: use transactionMeta for TransactionController events (#24003)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Use of a wrong field name which ends up as an error once published. ![ses-user-ops](https://github.com/MetaMask/metamask-extension/assets/569258/a36cd9e3-a6cd-491d-9341-3db768048fcb) [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24003?quickstart=1) ## **Related issues** Fixes: MetaMask/accounts-planning#359 ## **Manual testing steps** ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Gustavo Antunes <[email protected]>
1 parent 4f80914 commit 8a0e455

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

app/scripts/metamask-controller.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6058,7 +6058,7 @@ export default class MetamaskController extends EventEmitter {
60586058

60596059
this.controllerMessenger.publish(
60606060
'TransactionController:transactionStatusUpdated',
6061-
{ updatedTransactionMeta },
6061+
{ transactionMeta: updatedTransactionMeta },
60626062
);
60636063
}
60646064

0 commit comments

Comments
 (0)