Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ module.exports = {
// An object that configures minimum threshold enforcement for coverage results
coverageThreshold: {
global: {
branches: 86.95,
branches: 91.3,
functions: 100,
lines: 97.51,
statements: 97.51,
lines: 98.51,
statements: 98.51,
},
},

Expand Down
1 change: 1 addition & 0 deletions src/createStreamMiddleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ export default function createStreamMiddleware(options: Options = {}) {
const context = idMap[res.id as unknown as string];
if (!context) {
console.warn(`StreamMiddleware - Unknown response id "${res.id}"`);
return;
}

delete idMap[res.id as unknown as string];
Expand Down
11 changes: 11 additions & 0 deletions src/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,17 @@ describe('retry logic in middleware connected to a port', () => {
}).toThrow('StreamMiddleware - Retry limit exceeded for request id');
});

it('does not throw error when response is received for request not in map', async () => {
const res = { id: 1, jsonrpc, result: 'test' };

messageConsumer(res);

expect(() => {
messageConsumer(res);
messageConsumer(res);
}).not.toThrow();
});

it('does not retry if the request has no id', async () => {
// request and expected result
const req = { id: undefined, jsonrpc, method: 'test' };
Expand Down