Remove error throw when response is seen for unknown request

[jpuri]

Remove error thrown when response is seen for id which does not have corresponding request.

@Gudahtt : we had discussion about this on the last PR, but as I was playing around with DAPP action replay feature I could replicate this error. Reason I found is - as service worker restart we wait for state in background to be ready to send message to provider to replay actions (there are couple of asynchronous events to be executed for background state to be initialised). While this is being done provider may send send requests already which will also be replayed.

Thus we need to ignore duplicate responses which are possible after replay feature.

[Gudahtt]

Hmm, I'm still struggling to understand this. We aren't queuing up responses, just the requests, so I still don't understand how we'd get multiple responses.

Do you have more information on how to reproduce this?

[Gudahtt]

OK I think I understand how this could happen now. A request might get sent twice, and get two responses, in this scenario:

• The background service worker restarts
• The provider tries to send a message to the background
• The provider message is captured in the replay queue
• The provider message is handled by the background service worker after it has started back up, but before it has finished initialization
• Upon initialization, the background tells the provider that it has finished initialization, so any unhandled responses are replayed.
• The original request is handled by the background, and a response is sent
• The second request is handled by the background, and a response is sent

What I was missing is that I hadn't realized there was a state where the service were was still initializing, but it was able to receive requests.

[Gudahtt]

LGTM!