Skip to content

Conversation

@metalurgical
Copy link
Contributor

No description provided.

@metalurgical metalurgical marked this pull request as ready for review January 17, 2024 04:23
@ieow
Copy link
Collaborator

ieow commented Jan 17, 2024

the function name should be in snake_case or camelCase?
Should we make the input and output of the serialized as Data instead of hex string?
we need to update the following prs for the breaking api changes
MetaMask/tss-client-swift#14
MetaMask/torus-utils-swift#78

@metalurgical
Copy link
Contributor Author

@ieow For swift, it doesn't complain if you use either, unless you enforce one style. Though perhaps we should use camel?

Thanks for the links.

@metalurgical
Copy link
Contributor Author

Think most of them are already camelCase.

@metalurgical metalurgical merged commit c91366b into main Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants