perf: speed up adding transactions #7205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update delegation address async.
matthewwalsh0
force-pushed
the
feat/mm-pay-perf
branch
from
d75622c to
c2e2d69
Compare
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
matthewwalsh0
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
OGPoyraz
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Minor optimisations to
addTransactionandaddTransactionBatchmethods:skipInitialGasEstimateset.disableUpgradeset.delegationAddressand instead update asynchronously.eth_getCoderequests when determining transaction type.References
Related to #6165
Checklist
Note
Speeds up
addTransaction/addTransactionBatchby allowing async gas estimation and skipping EIP-7702 upgrade checks, plus tighter type handling and first‑time interaction optimizations.skipInitialGasEstimatetoaddTransactionandaddTransactionBatch; when set, skip blocking gas calc and update gas fields asynchronously.delegationAddressasynchronously post-add; remove from initial snapshot, update later.disableUpgradetoTransactionBatchRequest; when set, bypass upgrade check and avoid type0x4(setCode) path.skipInitialGasEstimatefrom batch to underlyingaddTransaction.typedirectly; only infer when not supplied.datawhentypeistokenMethodTransferortokenMethodTransferFrom; otherwise fall back toto.noopto safely swallow async errors; minor test updates and slight coverage threshold tweak.Written by Cursor Bugbot for commit 4ed214f. This will update automatically on new commits. Configure here.