-
-
Notifications
You must be signed in to change notification settings - Fork 256
feat: add address scanning to phishing controller #7118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+421
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imblue-dabadee
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Introduces
scanAddresswith per-chain caching, new types, and messenger action to screen EVM addresses via Security Alerts API.src/PhishingController.ts)scanAddress(chainId, address)hittingSECURITY_ALERTS_BASE_URL + ADDRESS_SCAN_ENDPOINTwith 5s timeout; returnsAddressScanResultand caches perchainId+address.addressScanCache(state, metadata), cache manager, defaults (DEFAULT_ADDRESS_SCAN_CACHE_TTL/MAX_SIZE), and options (addressScanCacheTTL/MaxSize).PhishingController:scanAddressand export constantsSECURITY_ALERTS_BASE_URL,ADDRESS_SCAN_ENDPOINT.AddressScanResult,AddressScanResultType,AddressScanCacheData; extend chain ID map; export new types/enums viaindex.ts.PhishingController.test.ts)scanAddresstests: success, HTTP errors, timeout, validation, normalization, caching (including per-chain).addressScanCache.Written by Cursor Bugbot for commit 6e3e5d1. This will update automatically on new commits. Configure here.