fix: improve transaction type detection when contract code lookup fails #6206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistevam
changed the title
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
OGPoyraz
previously approved these changes
Aug 1, 2025
| } | ||
|
|
||
| if (!isContractAddress) { | ||
| if (!isContractAddress && !hasReadAddressAsContractFailed) { |
There was a problem hiding this comment.
Bug: Simple Send Misclassified as Contract Interaction
When eth_getCode fails, the updated logic bypasses the simpleSend classification. This causes plain native asset transfers (those with no transaction data) to be incorrectly categorized as contractInteraction. This regresses behavior for simple sends, especially on providers where getCode intermittently errors (e.g., BNB), affecting UI and downstream logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The issue happens when users tries to send a token but provider returns an error when trying to identify if the address is a contract or not. It's an edge case identified on BNB.
This PR improves transaction type detection logic when interacting with an address that may or may not be a contract. Previously, if an error occurred while trying to determine whether an address was a contract (via eth_getCode), the logic would default to returning
simpleSend, which could lead to incorrect transaction classification.Key Changes
Improved error handling in
readAddressAsContract:This helper now returns an error field alongside
contractCodeandisContractAddress, enabling downstream logic to make better-informed decisions.Enhanced
determineTransactionTypelogic:If
eth_getCodefails, we no longer assume asimpleSend. Instead, we:Fallback to checking the presence of transaction data and attempt decoding via the 4-byte method selector.
References
Fixes MetaMask/metamask-mobile#16574
Changelog
Checklist