fix: move @metamask/keyring-controller to dependency in @metamask/accounts-controller
#4425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
approved these changes
Jun 18, 2024
montelaidev
deleted the
fix/keyring-controller-as-dev-dep-in-accounts-controller
branch
staging-devin-ai-integration bot
pushed a commit
to Devin-Applications/core-devin
that referenced
this pull request
Jul 11, 2024
…accounts-controller` (MetaMask#4425) ## Explanation This PR moves `@metamask/keyring-controller` to dependency from devDependency in `@metamask/accounts-controller` ## References ## Changelog ### `@metamask/accounts-controller` - **CHANGED**: move `@metamask/keyring-controller` from `devDependencies` to `dependencies` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR moves
@metamask/keyring-controllerto dependency from devDependency in@metamask/accounts-controllerReferences
Changelog
@metamask/accounts-controller@metamask/keyring-controllerfromdevDependenciestodependenciesChecklist