Release/145.0.0 #4229
Release/145.0.0 #4229
Conversation
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
I've looked at @metamask/approval-controller, @metamask/base-controller, @metamask/gas-fee-controller, and @metamask/network-controller (which were the packages connected to this package) and confirmed that we can safely release this package alone.
That said, I made some suggestions to satisfy lint and make this changelog more useful for consumers.
|
|
||
| ### Uncategorized | ||
|
|
||
| - fix: simulation should handle NFT mints ([#4217](https://github.com/MetaMask/core/pull/4217)) |
There was a problem hiding this comment.
We like to be clear about the changes that are made to the API or to the behavior of the package rather than repeating the name of the commit message. If you were to explain this to a consumer of the package, how would you do it? (Tip: you could try summarizing your PR description, keeping in mind that consumers don't know about getTokenBalanceTransactions or getTokenBalanceChanges, since they're private to the simulation file, so we might not want to figure out a way to describe it more generally)
There was a problem hiding this comment.
Done. Thank you for the clear explanation.
|
|
||
| ## [28.1.1] | ||
|
|
||
| ### Uncategorized |
There was a problem hiding this comment.
PR 4420 (referenced below) bumped gas-fee-controller in transaction-controller (since it was one of the packages that got released). So, we can file that under Changed:
| ### Uncategorized | |
| ### Changed | |
| - Bump `@metamask/gas-fee-controller` to ^15.1.0 ([#4220](https://github.com/MetaMask/core/pull/4220)) | |
Co-authored-by: Elliot Winkler <[email protected]>
Creates release 145, to release v28.1.1 of the TransactionController.
The intention is to hotfix transaction-controller 28.1.1 into the Extension along with #4217