deps(permission-controller): update to @metamask/json-rpc-engine, @metamask/rpc-errors
#1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter @metamask/rpc-errors upgrade
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @metamask/[email protected] |
legobeat
force-pushed
the
deps-json-rpc-engine
branch
from
79103a1 to
7624988
Compare
Mrtenz
reviewed
Oct 2, 2023
packages/permission-controller/src/PermissionController.test.ts
Outdated
Show resolved
Hide resolved
legobeat
force-pushed
the
deps-json-rpc-engine
branch
from
0470b2e to
6c34a9e
Compare
Mrtenz
requested changes
Oct 3, 2023
packages/permission-controller/src/PermissionController.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
approved these changes
Oct 3, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…@metamask/rpc-errors` (#1749)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…@metamask/rpc-errors` (#1749)
MajorLift
pushed a commit
that referenced
this pull request
Oct 12, 2023
…@metamask/rpc-errors` (#1749)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
@metamask/json-rpc-engineand@metamask/utils#1724 + Use@metamask/rpc-errorsinapproval-controller#1731@metamask/rpc-methods@^1.0.1References
Changelog
@metamask/permission-controllerRestrictedMethodParametersno longer acceptsvoidas type.json-rpc-engine@^6.1.0@metamask/json-rpc-engine@^7.1.1eth-rpc-errors@^4.0.2@metamask/rpc-errors@^6.0.0Checklist