Skip to content

Migrate eth-json-rpc-provider into core monorepo (1/2) #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MajorLift merged 34 commits into from
Oct 2, 2023
Merged

Migrate eth-json-rpc-provider into core monorepo (1/2) #1737

MajorLift merged 34 commits into from
Oct 2, 2023

Conversation

@MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Sep 27, 2023 •
edited
Loading

Explanation

This is the first of two PRs that will migrate eth-json-rpc-provider into the core monorepo by following these steps: #1079 (comment).

  • This PR focuses on migrating the git history of the original package.
    • eth-json-rpc-provider is moved into a temporary directory in core (merged-packages/) with git history fully intact.
    • This PR will be merged without squashing to preserve the git history.
  • The second PR will remove the merged-packages/ directory and integrate eth-json-rpc-provider into the packages/ directory, resolving any issues arising from applying core monorepo linter/compiler/build settings to the newly added package.

Blocked by

References

Changelog

N/A since @metamask/eth-json-rpc-provider isn't usable from the monorepo as of this PR.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Gudahtt and others added 25 commits February 8, 2023 18:30
@Gudahtt
Initial commit
8a2290f
@Gudahtt
Initial repository setup (#5)
504a752 
The package manifest, README, and PR template have been updated.
@Gudahtt @adonesky1
Migrate both provider functions (#6)
315c9c0 
* Migrate both provider functions

The functions `providerFromEngine` and `providerFromMiddleware` have
been migrated from `@metamask/eth-json-rpc-middleware`.

The `SafeEventEmitterProvider` is now a class with its own separate
module, rather than a type. Hopefully this will help prevent future
type errors. The error in the `SafeEventEmitterProvider` type in
`@metamask/eth-json-rpc-middleware` has been corrected; the response in
in the callback is now optional.

Everything should be fully documented and tested.

* Export type

* Fix spelling mistake

Co-authored-by: Alex Donesky <[email protected]>

* Improve test names

---------

Co-authored-by: Alex Donesky <[email protected]>
@dependabot
Bump @metamask/eslint-config-jest from 11.0.0 to 11.1.0 (#1)
123ccd5 
Bumps [@metamask/eslint-config-jest](https://github.com/MetaMask/eslint-config) from 11.0.0 to 11.1.0.
- [Release notes](https://github.com/MetaMask/eslint-config/releases)
- [Commits](MetaMask/eslint-config@v11.0.0...v11.1.0)

---
updated-dependencies:
- dependency-name: "@metamask/eslint-config-jest"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @Gudahtt
Bump @metamask/eslint-config from 11.0.2 to 11.1.0 (#2)
a4273cb 
Bumps [@metamask/eslint-config](https://github.com/MetaMask/eslint-config) from 11.0.2 to 11.1.0.
- [Release notes](https://github.com/MetaMask/eslint-config/releases)
- [Commits](MetaMask/eslint-config@v11.0.2...v11.1.0)

---
updated-dependencies:
- dependency-name: "@metamask/eslint-config"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mark Stacey <[email protected]>
@dependabot @Gudahtt
Bump @metamask/eslint-config-typescript from 11.0.2 to 11.1.0 (#3)
bece2c4 
Bumps [@metamask/eslint-config-typescript](https://github.com/MetaMask/eslint-config) from 11.0.2 to 11.1.0.
- [Release notes](https://github.com/MetaMask/eslint-config/releases)
- [Commits](MetaMask/eslint-config@v11.0.2...v11.1.0)

---
updated-dependencies:
- dependency-name: "@metamask/eslint-config-typescript"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mark Stacey <[email protected]>
@dependabot @Gudahtt
Bump @metamask/eslint-config-nodejs from 11.0.1 to 11.1.0 (#4)
c9c6443 
Bumps [@metamask/eslint-config-nodejs](https://github.com/MetaMask/eslint-config) from 11.0.1 to 11.1.0.
- [Release notes](https://github.com/MetaMask/eslint-config/releases)
- [Commits](MetaMask/eslint-config@v11.0.1...v11.1.0)

---
updated-dependencies:
- dependency-name: "@metamask/eslint-config-nodejs"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mark Stacey <[email protected]>
@Gudahtt
Decrement version ahead of v1 release (#7)
5f652b1 
The version has been changed to v0.0.1 so that the first release can be
v1. I set this to v1 forgetting that our release automation would also
attempt to set this.
@github-actions @Gudahtt
1.0.0 (#8)
328a43e 
* 1.0.0

* Update changelog

---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>
@legobeat
deps: Switch from json-rpc-engine to @metamask/json-rpc-engine (#16)
c4eb3e3 
* deps: @metamask/safe-event-emitter@^2.0.0->^3.0.0
* deps: migrate from json-rpc-engine to @metamask/json-rpc-engine
@github-actions @legobeat
1.0.1 (#18)
06c41f6 

---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: legobt <[email protected]>
@legobeat
Retract v1.0.1 (#18) (#19)
3cc4c88 
v1.0.1 contains two changes that should have been considered
semver-major:

- Type-interface incompatability with previous version (MetaMask/json-rpc-engine#139)
- Introduced dependency `@metamask/json-rpc-engine` indicates a minimum
  supported Node.js version of 16. This prevents the module from
  installing on some package manager configurations, like default
  yarn classic.

This will be re-released as v2.0.0.
@legobeat
BREAKING: Update minimum Node.js version to 16 (#20)
5d8309f 
Required by update of `@metamask/json-rpc-engine` (#16)
@legobeat
Revert "BREAKING: Update minimum Node.js version to 16 (#20)" (#22)
d8c8315 
This reverts commit 5d8309f.
@legobeat
BREAKING: Update minimum Node.js version to 16 (#23)
9e24300 
Required by update of `@metamask/json-rpc-engine` (#16)
@github-actions @legobeat
2.0.0 (#21)
de124c4 

---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: legobt <[email protected]>
@legobeat
deps: @metamask/utils@^5.0.1->^8.1.0; bump @metamask/json-rpc-engine (#…
b0cea6f 
…25)

* deps: @metamask/utils@^5.0.1->^8.1.0
* deps: @metamask/json-rpc-engine@^7.0.0->^7.1.0
* deps: @metamask/utils@^7.1.0->^8.1.0
@github-actions @legobeat @Mrtenz
2.1.0 (#26)
0aa45a9 
---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: legobt <[email protected]>
Co-authored-by: legobeat <[email protected]>
Co-authored-by: Maarten Zuidhoorn <[email protected]>
@MajorLift
Decrement TypeScript to ~4.6.3 ahead of migration to core monorepo
c624508 
- match compiler options with core monorepo
  - passes all tests

Closes #1682
@MajorLift
Update packages for eslint and prettier ahead of migration to core mo…
b691212 
…norepo

- added: `eslint-plugin-promise`
- removed: `eslint-plugin-node`

See: #1683
@MajorLift
linter fix from eslint version update
f66efc9
@MajorLift
Apply core monorepo eslint config
c852c4f 
- added `eslint-import-resolver-typescript` v2.5.0 as dependency

See: #1683
@MajorLift
Bump dependency versions to align with core monorepo v77.0.0
3f97d73
@MajorLift
Bump TypeScript to v4.8.4 to align with planned version update in cor…
3ad0c38 
…e monorepo

- See #1718
- See MetaMask/eth-json-rpc-provider#27
- Closes #1682
@MajorLift
Restore TypeScript compiler options that are not enabled in the core …
919af45 
…monorepo
@socket-security
Copy link

socket-security bot commented Sep 27, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/auto-changelog 3.1.0 None +0 166 kB metamaskbot
eslint-config-prettier 8.5.0 None +9 1.21 MB lydell
jest 28.1.3 None +122 14.1 MB simenb
ts-jest 28.0.8 None +123 14.3 MB kul
@types/jest 28.1.8 eval +26 2.84 MB types
prettier-plugin-packagejson 2.4.5 None +4 15.9 MB matzkoh
@types/node 17.0.23 None +0 1.68 MB types
depcheck 1.4.3 filesystem +54 17.4 MB rumpl
prettier 2.7.1 None +0 15.8 MB prettier-bot
typedoc 0.23.28 network +7 11.3 MB typedoc-bot
eslint-plugin-jest 27.1.5 None +16 2.96 MB simenb

@socket-security
Copy link

socket-security bot commented Sep 27, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], @babel/[email protected], @lavamoat/[email protected], [email protected], [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@MajorLift
Merge remote-tracking branch 'eth-json-rpc-provider/230925-migrate-to…
6d23ef7 
…-monorepo-deps-linter-configs' into 230927-migrate-eth-json-rpc-provider
@MajorLift MajorLift force-pushed the 230927-migrate-eth-json-rpc-provider branch from e22f806 to 6d23ef7 Compare September 27, 2023 17:42
@MajorLift MajorLift changed the title Migrate eth-json-rpc-provider into core monorepo Migrate eth-json-rpc-provider into core monorepo (1/2) Sep 27, 2023
@MajorLift MajorLift self-assigned this Sep 27, 2023
@MajorLift MajorLift added enhancement New feature or request team-wallet-framework Deprecated: Please use `team-core-platform` instead. labels Sep 27, 2023
@MajorLift MajorLift linked an issue Sep 27, 2023 that may be closed by this pull request
Fully migrate eth-json-rpc-provider into core monorepo #1551
Closed
@MajorLift MajorLift removed a link to an issue Sep 27, 2023
Fully migrate eth-json-rpc-provider into core monorepo #1551
Closed
@MajorLift MajorLift mentioned this pull request Sep 27, 2023
Merged
33 tasks
MajorLift and others added 3 commits September 28, 2023 07:52
@MajorLift
Merge branch 'main' into 230927-migrate-eth-json-rpc-provider
f998bf5
@MajorLift
Align ESLint, Prettier packages and configs with core monorepo ahead …
db9598b 
…of migration (#28)

## Description
- This PR aligns the ESLint and Prettier packages and configs in this repo with the core monorepo.
- This is a preparation step for migrating the `eth-json-rpc-provider` package into the core monorepo.
- Originally, the plan was to decrement the TypeScript version to align with the core monorepo, but following [this discussion](MetaMask/eth-json-rpc-provider#27), we've opted to use TypeScript version v4.8.4, and preserve the compiler options in this package that aren't enabled in the core monorepo.

## References
- See #1551
- Closes #1683
- Closes #1682 (is superseded by this PR)
@legobeat
Add missing ISC license information (#24)
9ecb507 
Add ISC license
@MajorLift MajorLift marked this pull request as draft September 29, 2023 18:04
github-actions bot and others added 2 commits September 29, 2023 13:11
@github-actions @MajorLift
2.2.0 (#29)
d3a9f01 
* 2.2.0

* Update CHANGELOG.md

* Add license update as entry to CHANGELOG.md

---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: Jongsun Suh <[email protected]>
@MajorLift
Merge remote-tracking branch 'eth-json-rpc-provider/main' into 230927…
752cff9 
…-migrate-eth-json-rpc-provider
@MajorLift MajorLift force-pushed the 230927-migrate-eth-json-rpc-provider branch from d685226 to 752cff9 Compare September 29, 2023 20:15
@MajorLift MajorLift marked this pull request as ready for review September 29, 2023 20:25
mikesposito
mikesposito approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MajorLift MajorLift merged commit 10b8f26 into main Oct 2, 2023
@MajorLift MajorLift deleted the 230927-migrate-eth-json-rpc-provider branch October 2, 2023 14:55
MajorLift added a commit that referenced this pull request Oct 2, 2023
@MajorLift
Revert "Migrate eth-json-rpc-provider into core monorepo (1/2) (#1737…
7c5df78 
…)"

This reverts commit 10b8f26.
@MajorLift MajorLift mentioned this pull request Oct 2, 2023
Merged
MajorLift added a commit that referenced this pull request Oct 2, 2023
@MajorLift
Revert "Migrate eth-json-rpc-provider into core monorepo (1/2)" (#1753
eca9e10 
)

Reverts #1737

- The intention for this PR was to preserve the full git history of the
original repo, which means the commits shouldn't have been squashed
while merging.
- #1737 will be re-merged using the `--no-ff` option, which will be
temporarily enabled by admin.
@MajorLift MajorLift restored the 230927-migrate-eth-json-rpc-provider branch October 2, 2023 15:21
MajorLift added a commit that referenced this pull request Oct 11, 2023
@MajorLift
Revert "Migrate eth-json-rpc-provider into core monorepo (1/2)" (#1753
0747521 
)

Reverts #1737

- The intention for this PR was to preserve the full git history of the
original repo, which means the commits shouldn't have been squashed
while merging.
- #1737 will be re-merged using the `--no-ff` option, which will be
temporarily enabled by admin.
MajorLift added a commit that referenced this pull request Oct 11, 2023
@MajorLift
Revert "Migrate eth-json-rpc-provider into core monorepo (1/2)" (#1753
a9fa7a4 
)

Reverts #1737

- The intention for this PR was to preserve the full git history of the
original repo, which means the commits shouldn't have been squashed
while merging.
- #1737 will be re-merged using the `--no-ff` option, which will be
temporarily enabled by admin.
MajorLift added a commit that referenced this pull request Oct 12, 2023
@MajorLift
Revert "Migrate eth-json-rpc-provider into core monorepo (1/2)" (#1753
f3a6c45 
)

Reverts #1737

- The intention for this PR was to preserve the full git history of the
original repo, which means the commits shouldn't have been squashed
while merging.
- #1737 will be re-merged using the `--no-ff` option, which will be
temporarily enabled by admin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikesposito mikesposito mikesposito approved these changes

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

@cryptodev-2s cryptodev-2s Awaiting requested review from cryptodev-2s

Assignees

@MajorLift MajorLift

Labels

enhancement New feature or request team-wallet-framework Deprecated: Please use `team-core-platform` instead.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MajorLift @mikesposito @Gudahtt @legobeat