Added section related to https deployment #556 #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterPetrik
reviewed
Feb 20, 2025
fernandinand
requested review from
PeterPetrik
and removed request for
PeterPetrik
varmar05
reviewed
Feb 24, 2025
MarcelGeo
requested changes
Feb 24, 2025
There was a problem hiding this comment.
I think do not mention docker-compose here. As we discussed with @varmar05 , ssl-proxy.conf is just example of how to use it with nginx. You can follow this guide on your infrastructure. If you want to use it with docker-compose as you mentioned, ssl-proxy.conf should be updated also with specific paths from nginx.conf (/download , etc.)
I think that you can mention here also specific security headers from ssl-proxy.conf.
alex-cit
approved these changes
Feb 26, 2025
MarcelGeo
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this new section related to HTTPS deployment