Fix memory leak related to MerginProject object #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that we are creating MerginProject objects way too much, and the cleanup of it may not be handled properly because of a cyclic reference between MerginProject and its internal GeoDiff context object. It is going to be both safer and faster to create MerginProject for a particular working directory once and then keep it cached. Fun fact: the leak is not showing up in "top" commend, only in docker's stats about memory...
alexbruy
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
It turns out that we are creating MerginProject objects way too much, and the cleanup of it may not be handled properly because of a cyclic reference between MerginProject and its internal GeoDiff context object.
It is going to be both safer and faster to create MerginProject for a particular working directory once and then keep it cached.
Fun fact: the leak is not showing up in "top" commend, only in docker's stats about memory...