Add password and superuser args to user role resource

[bobbyiliev]

Fixes #730

Blocked on: MaterializeInc/materialize#33697

[bobbyiliev]

Open to suggestions here if we should actually make the login a separate attribute, so instead of:

resource "materialize_role" "admin_user" {
  name      = "admin"
  password  = "adminpass"
  superuser = true
}

Users would need to explicitly set this, eg:

resource "materialize_role" "admin_user" {
  name      = "admin"
  password  = "adminpass"
  login     = true
  superuser = true
}

[DAlperin]

Yeah I think so. We def have users who use non-login roles to manage grants, so lets make it explicit here.

[bobbyiliev]

Sounds good! Will get this updated.

[bobbyiliev]

Tests will be failing until we get the new image with MaterializeInc/materialize#33697

[jubrad]

Approving because the code seems solid, but I do have a few comments that might be nice to address first.

[jubrad]

I believe this needs login set to true

[jubrad]

I'm wondering if we should just always provide all WIH options

append(p, ` WITH`)

if b.login {
   append(p, ` LOGIN`)
} else {
   append(p, ` NOLOGIN`)
}

if b.password {
  p = append(p, fmt.Sprintf(` PASSWORD %s`, QuoteString(b.password)))
} else {
  p = append(p, ` NOPASSWORD `)
}

[bobbyiliev]

Hm yes I like this! Will update the PR now.

[bobbyiliev]

@jubrad Actually this might not work and I'm now remembering why I did it that way initially :/

Because in SaaS, where we don't have password enabled, it would make the role resource unusable I think?