test: fix busy replication slot test #34280
Merged
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test's intention was to spawn a reader of the replication and ensure that Materialize can successfully reclaim it by killing the appropriate server process. However, the WAL reader that we spawned also advanced the slot forward without Materialize having seen and committed that section. To avoid this we pass an extremely long fsync-interval parameter that will result in the slot being busy but not advanced. Fixes MaterializeInc/database-issues#8447 Signed-off-by: Petros Angelatos <[email protected]>
martykulma
approved these changes
Dec 1, 2025
Contributor
martykulma
left a comment
martykulma
left a comment
There was a problem hiding this comment.
Nice, thanks @petrosagg !!
Was there a reason you selected a specific value here instead of 0 (disables fsync)?
Contributor
Author
Yes, if you set |
def-
added a commit
to def-/materialize
that referenced
this pull request
Dec 3, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test's intention was to spawn a reader of the replication and ensure that Materialize can successfully reclaim it by killing the appropriate server process.
However, the WAL reader that we spawned also advanced the slot forward without Materialize having seen and committed that section. To avoid this we pass an extremely long fsync-interval parameter that will result in the slot being busy but not advanced.
Fixes MaterializeInc/database-issues#8447
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.