Skip to content

orchestratord test: Fix upgrades #34214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2025
Merged

orchestratord test: Fix upgrades #34214

merged 1 commit into from
Nov 27, 2025
+322 −136

Conversation

@def-
Copy link
Contributor

@def- def- commented Nov 19, 2025 •
edited
Loading

Shouldn't be set, as noted by @alex-hunt-materialize
Test run: https://buildkite.com/materialize/nightly/builds/14124

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

alex-hunt-materialize
alex-hunt-materialize reviewed Nov 19, 2025
View reviewed changes
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 3 times, most recently from 8304776 to b696e2d Compare November 20, 2025 11:37
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch from b696e2d to b42d451 Compare November 20, 2025 13:34
@alex-hunt-materialize alex-hunt-materialize mentioned this pull request Nov 20, 2025
Draft
5 tasks
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch from b42d451 to de0b470 Compare November 20, 2025 18:24
@def- def- requested a review from a team as a code owner November 20, 2025 18:24
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 2 times, most recently from 37aff13 to 65bc9f3 Compare November 20, 2025 20:13
@def- def- changed the title orchestratord test: rolling upgrade orchestratord test: rolling upgrade + introduce mz-debug Nov 21, 2025
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch from 65bc9f3 to 893dfa9 Compare November 21, 2025 16:37
@def- def- requested a review from doy-materialize November 21, 2025 16:41
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 2 times, most recently from 4c291fb to eddf132 Compare November 21, 2025 22:26
@def- def- marked this pull request as draft November 21, 2025 22:26
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 10 times, most recently from 373da48 to 11a9d24 Compare November 25, 2025 07:45
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 4 times, most recently from 4efe158 to 65f0f20 Compare November 25, 2025 17:03
@def- def- mentioned this pull request Nov 25, 2025
Merged
5 tasks
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 5 times, most recently from 9ededdc to e529e3d Compare November 26, 2025 08:04
@def- def- marked this pull request as ready for review November 26, 2025 08:09
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 3 times, most recently from f13042e to 52b67bc Compare November 26, 2025 09:36
@def- def- changed the title orchestratord test: rolling upgrade + introduce mz-debug orchestratord test: Fix upgrades Nov 26, 2025
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch from 52b67bc to 554797f Compare November 26, 2025 09:51
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 6 times, most recently from 615fc46 to 4823c98 Compare November 26, 2025 15:31
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch from 4823c98 to 4059031 Compare November 27, 2025 07:48
@def- def- enabled auto-merge November 27, 2025 09:34
@def- def- merged commit 781e751 into MaterializeInc:main Nov 27, 2025
140 checks passed
@def- def- deleted the pr-orchestratord-rolling-upgrade branch November 27, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-hunt-materialize alex-hunt-materialize alex-hunt-materialize approved these changes

@doy-materialize doy-materialize Awaiting requested review from doy-materialize

@bobbyiliev bobbyiliev Awaiting requested review from bobbyiliev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@def- @bobbyiliev @alex-hunt-materialize