Fix all warnings #145
Merged
Fix all warnings #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasDutartre
force-pushed
the
fix-warnings
branch
from
27f4d4d to
91fd2ba
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 95.56% 95.58% +0.01%
==========================================
Files 22 22
Lines 1330 1335 +5
==========================================
+ Hits 1271 1276 +5
Misses 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThomasDutartre
force-pushed
the
fix-warnings
branch
2 times, most recently
from
6ce6c6d to
73c36d2
Compare
ThomasDutartre
force-pushed
the
fix-warnings
branch
from
73c36d2 to
bd496c0
Compare
This works regardless of SwiftSyntax version and handles cases like "isolated inout"
Replace hardcoded "inout" string with TokenSyntax.keyword(.inout).text for more robust and version-independent inout parameter checking.
Matejkob
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.specifier is equal to specifiers.first
https://github.com/swiftlang/swift-syntax/pull/2433/files