Skip to content

Minor bugfix with new request module #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2015
Merged

Minor bugfix with new request module #1

merged 3 commits into from
Jul 16, 2015

Conversation

kredmer
Copy link

@kredmer kredmer commented Jun 21, 2014

  • in order to work you had to set options.path
  • if sendImmediately is not set to false, request will try to make a basic auth

TODO:

  • update Readme for request implementation
  • update tests (thank you for the tests - helped me a lot)

MarkPaxton added a commit that referenced this pull request Jul 16, 2015
@MarkPaxton
Merge pull request #1 from kredmer/master
36e0a5a 
Minor bugfix with new request module
@MarkPaxton MarkPaxton merged commit 36e0a5a into MarkPaxton:master Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kredmer @MarkPaxton