-
Notifications
You must be signed in to change notification settings - Fork 142
Support for expressive layouts with page.md #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {{ MAIN_CONTENT_BODY }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {{ MAIN_CONTENT_BODY }} |
1 change: 1 addition & 0 deletions
1
test/functional/test_site_convert/expected/markbind/layouts/default/page.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {{ MAIN_CONTENT_BODY }} |
6 changes: 6 additions & 0 deletions
6
test/functional/test_site_expressive_layout/_markbind/footers/footer.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <footer> | ||
| <!-- Support MarkBind by including a link to us on your landing page! --> | ||
| <div class="text-center"> | ||
| <small>[Generated by {{MarkBind}}]</small> | ||
| </div> | ||
| </footer> |
Empty file.
Empty file.
Empty file.
Empty file.
3 changes: 3 additions & 0 deletions
3
test/functional/test_site_expressive_layout/_markbind/layouts/default/imported.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <variable name="importedVar">This is an importedVar</variable> | ||
|
|
||
| This content can be imported to the bottom of the page |
Empty file.
16 changes: 16 additions & 0 deletions
16
test/functional/test_site_expressive_layout/_markbind/layouts/default/page.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <variable name="layoutVar">Variable from layout</variable> | ||
| <import importedVar from="imported.md" as="imported" /> | ||
|
|
||
| {{ layoutVar }} | ||
|
|
||
| {{ importedVar }} | ||
crphang marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| <panel header="Expanded panel" alt="Minimized panel" type="success" minimized> | ||
| Math formulas | ||
| </panel> | ||
|
|
||
| {{ MAIN_CONTENT_BODY }} | ||
|
|
||
| Bottom Content | ||
|
|
||
| <include src="imported.md" /> | ||
4 changes: 4 additions & 0 deletions
4
test/functional/test_site_expressive_layout/_markbind/layouts/default/scripts.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // eslint-disable-next-line no-undef | ||
| MarkBind.afterSetup(() => { | ||
| // Include code to be called after MarkBind setup here. | ||
| }); |
Empty file.
4 changes: 4 additions & 0 deletions
4
test/functional/test_site_expressive_layout/_markbind/variables.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <variable name="example"> | ||
| To inject this HTML segment in your markbind files, use {{ example }} where you want to place it. | ||
| More generally, surround the segment's id with double curly braces. | ||
| </variable> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads better this way?
Alternatively, can be written this way (i.e., avoid breaking sentences across boxes):