Remove CLI commands: render, include #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Other, please explain:
Remove unused CLI commands - render and include.
Fixes #503.
What is the rationale for this request?
As mentioned in #503, these commands are not being used in development / testing. Hence, we can drop the render and include commands.
What changes did you make? (Give an overview)
Removed render and include CLI commands (in
index.js).Provide some example code that this change will affect:
N.A.
Is there anything you'd like reviewers to focus on?
Ensure that the deletions aren't breaking anything.
Testing instructions:
Build markbind-cli locally (
npm installandnpm linkin the repo directory) and check that render and include commands aren't accepted. Additionally check if other commands are working properly.