-
Notifications
You must be signed in to change notification settings - Fork 142
Plugins: Support shorthand syntax processing #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So this is going to be specified by the user in the site configuration file? If code is involved, seems better to have it in a |
|
Oh yeah, js plugin definitely. I'm just suggesting we have some kind of framework that can be generalized to different syntax transformations. |
Understand the point, my question originated because you mentioned the following:
Will look forward to your actual implementation. |
9de6a39 to
fb32bcc
Compare
|
Reviving this PR now that #474 is merged. Moved to This plugin is kind of empty right now. I'm not sure if it's worth exposing to public (documenting as a plugin) at the moment. How about: Add a mechanism for 'always-run' plugins i.e. without having to include it in
This was made as a plugin more for the sake of keeping the code base clean, users are unlikely to need to disable it. Having it always on saves the user from having to add it in every time. This can also be applied to other features that should be always enabled, such as
|
yamgent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a mechanism for 'always-run' plugins i.e. without having to include it in
plugins.
As mentioned by Prof in #474 (comment) perhaps this can be enabled by default and allow the user to disable it if necessary.
We can then adjust the documentation as necessary then.
But for now the PR is sound and can actually be incorporated into the codebase. 👍
|
Waiting on #702 so this can be converted to always-on |
fb32bcc to
35df561
Compare
|
Sorry for late update. Plugin has been converted to default (always on) and rebased. |
|
Propose a merge commit message. |
|
How's this? |
|
Revised your commit message to use |
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] New feature
Fixes #492
What is the rationale for this request?
We want to be able to support shorthand syntax for certain elements.
What changes did you make? (Give an overview)
Have a feature that transpiles shorthand syntax into proper Markbind syntax before processing.
The current implementation is just a proof of concept. Better to migrate this function to external plugin once #474 is merged.
We can generalize this plugin so other shorthands can be added easily as well. I'm thinking we can handle these all together since they are too small to warrant their own functions/plugins.
Something like this perhaps?