Use src instead of lib directory #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lib/Page.js → src/Page.js etc. |
Contributor
Author
|
My bad, must've missed it, updated |
jamos-tay
force-pushed
the
move-files-to-src
branch
from
61bce07 to
67d6f40
Compare
Member
|
As in the original comment, shouldn't it be |
jamos-tay
force-pushed
the
move-files-to-src
branch
2 times, most recently
from
f7bdaab to
9e9fa85
Compare
Contributor
Author
|
Okay I made sure to double check it this time 😐 If possible maybe we can merge the PRs from the other guys in first, this PR will mess up their changes and I don't want to trouble them. |
Member
|
|
Contributor
Author
|
Updated |
yamgent
approved these changes
Dec 15, 2018
Member
|
@jamos-tay Need you to resolve conflict for this PR. |
jamos-tay
force-pushed
the
move-files-to-src
branch
from
91dd0e9 to
5e0e95b
Compare
Contributor
Author
|
Sure, updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Other, please explain: Change directory structure
Fixes #471
What is the rationale for this request?
Follow up from #467
What changes did you make? (Give an overview)
Revamp directory structure to use
srcinstead of lib.