Skip to content

Bootstrap 5: Namespace data attributes #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoarmanda merged 3 commits into from
Apr 12, 2022
Merged

Bootstrap 5: Namespace data attributes #1892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5446b55
data attrs: data-bs-spy
jovyntls Apr 8, 2022
55c8550
data attrs: data-bs-target
jovyntls Apr 8, 2022
f84b4d4
data attrs: data-bs-offset
jovyntls Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/test/functional/test_site/expected/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
const baseUrl = '/test_site'
</script>

<body data-spy="scroll" data-target="#mb-page-nav" data-offset="100">
<body data-bs-spy="scroll" data-bs-target="#mb-page-nav" data-bs-offset="100">
<div id="app">

<div>
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/test/functional/test_site/expected/testPageNav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
const baseUrl = '/test_site'
</script>

<body data-spy="scroll" data-target="#mb-page-nav" data-offset="100">
<body data-bs-spy="scroll" data-bs-target="#mb-page-nav" data-bs-offset="100">
<div id="app">

<div>
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/test/functional/test_site_templates/test_default/expected/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
const baseUrl = ''
</script>

<body data-spy="scroll" data-target="#mb-page-nav" data-offset="100">
<body data-bs-spy="scroll" data-bs-target="#mb-page-nav" data-bs-offset="100">
<div id="app">
<header fixed>
<navbar type="dark">
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/Page/page.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<script>
const baseUrl = '{{ baseUrl }}'
</script>
<body {% if hasPageNav %} data-spy="scroll" data-target="#mb-page-nav" data-offset="100" {% endif %}>
<body {% if hasPageNav %} data-bs-spy="scroll" data-bs-target="#mb-page-nav" data-bs-offset="100" {% endif %}>
{{ content }}
</body>
{{- pageUserScriptsAndStyles -}}
Expand Down