-
Notifications
You must be signed in to change notification settings - Fork 142
Migrate popovers and tooltips to floating-vue #1856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few questions:
- Is bootstrap-vue still in use? There are still some remnants of it here.
- If its not in use maybe there is a need to run
npm run updatetestalso
Yep! Mentioned in the PR description that it can be removed in a separate PR to keep this one small, what do you think? I'm not sure if it's best to just remove it along with this PR too since it's related. |
Ah missed that part in your description XD. I think it makes more sense to remove it in a separate PR, since quite a few tests files will be affected by it too. |
|
@kaixin-hc Thanks for the catch! I moved the default Didn't realise the decrease opacity of tooltips had changed too D: Will maintain the same styles by replicating the previous opacity. For the positioning issue, the auto-repositioning is working - the issue seems to be due to different ways of handling cases where the screen is small. Currently on the master branch, when the tooltip "flips" and there's still not enough space, the tooltip itself will move in (see the red circle no longer on the edge of the button): When floating-vue tries to reposition by flipping the tooltip, there's not enough space on the right either so it "gives up" and stays on the left. However, the tooltip stays on the edge of the button (see red circle), resulting in a cut-off tooltip: As a fix, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work overall, no issues on the code side but I found that the user side documentation has yet to be updated to remove the bootstrap reference.
For example here, the modal sizes here still link to bootstrap, perhaps we can update it?
Oops missed that out 😅 I can update it in a separate PR (maybe the one to fully remove bootstrap-vue since that will involve updating docs as well)! |
I agree that this is a worthwhile tradeoff! WRT the documentation, I think it's better to have it reflect the actual functionality in this PR? Or I suppose we can make an issue for it or add it to an existing issue to make sure it doesn't get forgotten |
Which documentation are you referring to? 😅 |
ah the thing that @ong6 raised, the table with modal sizes for example? |
Yep! I can address it in a separate PR (the one removing bootstrap-vue entirely) since it's not directly related to popovers and tooltips. For the modals, to the user it should work and look the same, just that the implementation is no longer using bootstrap modals. |





What is the purpose of this pull request?
Part of #1702 , by removing the dependency on bootstrap-vue
Overview of changes:
Menucomponent from Floating VueTooltipcomponent from Floating Vueplacementhas been changed toplacement=topto preserve the same behaviour. floating-vue has the option forplacement=auto, but this tends to render popups to the right in small containers (where they previously would be on top). Since floating-vue automatically repositions popovers even for non-auto placements,placement=topis the closest to the original behaviour.Anything you'd like to highlight / discuss:
Should the full removal of bootstrap-vue be done in a separate PR?
Testing instructions:
There should be no noticeable change in behaviour or UI for popovers and tooltips
Proposed commit message: (wrap lines at 72 characters)
Checklist: ☑️