Skip to content

Conversation

@le0tan
Copy link
Contributor

@le0tan le0tan commented Mar 29, 2020

DevGuide needs to be updated as #990 migrated completely to NunJucks.

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

#990 removes ejs as a dependency
@le0tan le0tan requested a review from marvinchin March 29, 2020 07:44
Copy link
Contributor

@nbriannl nbriannl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Accurate documentation is always good for the health of the project.

@yash-chowdhary yash-chowdhary added the pr.DocsUpdate 📃 Pure changes to the documentation, such as typo, restructuring, etc label Apr 1, 2020
@le0tan le0tan merged commit eeddb9e into master Apr 1, 2020
@le0tan le0tan deleted the le0tan-patch-1 branch April 1, 2020 12:20
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr.DocsUpdate 📃 Pure changes to the documentation, such as typo, restructuring, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants