popover initiated by trigger: honor trigger attribute

[damithc]

When a popover is triggered by a <trigger> (example given below), honor the trigger="..." setting. The current one defaults to hover no matter what the setting is.

According to <trigger for="pop:xp-user-stories">XP</trigger>, the biggest difference

<popover id="pop:xp-user-stories" trigger="click">
  <div slot="content">
    <include src="../../common/References.md#xp-user-stories" />
  </div>
</popover>

[rachx]

Currently, it will always use the trigger attribute of the trigger (and ignore what is specified for the popover). This will work:

According to <trigger for="pop:xp-user-stories" trigger="click">XP</trigger>, 

<popover id="pop:xp-user-stories">
  <div slot="content">
    <include src="../../common/References.md#xp-user-stories" />
  </div>
</popover>

Do we want to always use the popover's trigger=.. attribute even when both are specified? It might be confusing that one can override another

[damithc]

Did I use the feature wrongly or both can have trigger attributes?

[rachx]

According to the docs, both can have trigger attributes.

But in the code, the popover's trigger attribute is always overwritten by the trigger's (which defaults to hover). Hence the bug.

This can be fixed and modified to honor the attribute specified for popover. But I think it is weird that both can be specified. Maybe remove that option for popover?

[damithc]

This can be fixed and modified to honor the attribute specified for popover. But I think it is weird that both can be specified. Maybe remove that option for popover?

Yes, we can remove it from popover.