Fix support for API endpoints that return nothing #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, for server responses such as 204 No Content, json() must not be called because it would fail.
MarcoMuellner
requested changes
Feb 22, 2023
Owner
MarcoMuellner
left a comment
MarcoMuellner
left a comment
There was a problem hiding this comment.
Please change the templates accordingly, the nesting makes it fairly hard to read. Otherwise thank you for fixing the issue :)
src/openapi_python_generator/language_converters/python/templates/aiohttp.jinja2
Outdated
Show resolved
Hide resolved
Owner
MarcoMuellner
left a comment
MarcoMuellner
left a comment
There was a problem hiding this comment.
Probably need to discuss what to return in this case.
| {% if return_type.complex_type %} | ||
| {% if return_type.list_type is none %} | ||
| {% if return_type.type is none or return_type.type.converted_type is none %} | ||
| return response.json() |
Owner
There was a problem hiding this comment.
I think return None is the correct approach here, instead of the dictionary, as the return type is also typed as None in this case afaik. It should be also in line to what the Openapi definition actually provides.
Author
There was a problem hiding this comment.
My bad, that is actually what I originally intended. I got confused by the logic inversion. Fixed the commit.
meck-gd
force-pushed
the
fix-returntype-none
branch
from
5ef1d62 to
27421c4
Compare
MarcoMuellner
approved these changes
Feb 23, 2023
Owner
|
Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some APIs may acknowledge requests with status 204 No Content and they won't provide a response body.