Remove unnecessary files #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aathish04
requested changes
May 27, 2020
There was a problem hiding this comment.
Could you please remove media_dir.txt as well?
Its path is manim/scene/media_dir.txt
https://www.github.com/ManimCommunity/manim/tree/master/manim%2Fscene%2Fmedia_dir.txt
|
@Aathish04 done |
XorUnison
approved these changes
May 27, 2020
|
Awesome. Also, I think you also have to remove the import for SceneFromVideo from It's at line 54 of the file. https://www.github.com/ManimCommunity/manim/tree/remove_unnecessary_files/manim%2F__init__.py#54 |
|
Ah good one @Aathish04 . Just did that. Thanks |
Aathish04
approved these changes
May 27, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96 and #85.