Skip to content

Allow videos to be embedded in Google Colab without explicitly setting config.media_embed = True #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Allow videos to be embedded in Google Colab without explicitly setting config.media_embed = True #3974

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d43ebf0
Treat the media_embed config value as a boolean in if statements (#3741)
skusel Oct 23, 2024
866ea81
Merge branch 'main' into media_embed_google_collab
chopan050 Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manim/utils/ipython_magic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def construct(self):

file_type = mimetypes.guess_type(config["output_file"])[0]
embed = config["media_embed"]
if embed is None:
if not embed:
# videos need to be embedded when running in google colab.
# do this automatically in case config.media_embed has not been
# set explicitly.
Expand Down
Loading