Fix SyntaxWarnings when building the docs and bump readthedocs to Python 3.13
#3924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGrace2282
added
the
maintenance
|
Curiously, this change apparently bumps up our documentation build time by about 2 minutes -- I can't really tell why. Should we try to bump the version of Python directly to 3.13 to see whether it makes a difference? |
|
We could try bumping to 3.13. I'm not sure if that would make it faster, though - there was an issue with 3.13 that made it 30% slower with Sphinx. Python reverted the change, but it's possible it could still be slower. I'm all for trying, though! For reference, the build times are: |
|
It did get slightly faster with python 3.13, with 15min 45 seconds! |
chopan050
changed the title
SyntaxWarnings when building the docsSyntaxWarnings when building the docs and bump readthedocs to Python 3.13
JasonGrace2282
added a commit
to JasonGrace2282/manim
that referenced
this pull request
Dec 16, 2024
behackl
pushed a commit
to JasonGrace2282/manim
that referenced
this pull request
Jan 19, 2025
behackl
added a commit
that referenced
this pull request
Jan 20, 2025
* First draft of Changelog for 0.19.0 * fix typos * added 3967 * Add #4037 * Update count 97 -> 98 * Add #4039 * Add #3930 and #4044 * Add this PR to changelog * Add small description to changelog * Add #3924, #3951, and #4038 * Bump Manim version to 0.19.0 * Update CITATION.cff to be more consistent * remove github-security[bot] * Feedback + missing PRs * add newly merged PRs * added more details to highlights + breaking changes * bump date * sort PRs in breaking changes section and include 3964 * sort highlights section * fix: add required configuration key in .readthedocs.yml * Update docs/source/changelog/0.19.0-changelog.rst --------- Co-authored-by: Benjamin Hackl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.123.13 (so it's easier to confirm there being noSyntaxWarningwithout having to build it).tagsattribute so that we can upgrade to Sphinx 9.0 without problems in the future