Skip to content

Fixed Mobject.put_start_and_end_on with same start and end point #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Fixed Mobject.put_start_and_end_on with same start and end point #3718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
375e536
fix put_start_and_end_on() at the same point
MontroyJosh Apr 23, 2024
19db2f5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion manim/mobject/mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1734,7 +1734,8 @@ def put_start_and_end_on(self, start: Point3D, end: Point3D) -> Self:
curr_start, curr_end = self.get_start_and_end()
curr_vect = curr_end - curr_start
if np.all(curr_vect == 0):
raise Exception("Cannot position endpoints of closed loop")
self.points = start
return self
target_vect = np.array(end) - np.array(start)
axis = (
normalize(np.cross(curr_vect, target_vect))
Expand Down
9 changes: 8 additions & 1 deletion tests/module/mobject/graphing/test_number_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import numpy as np

from manim import NumberLine
from manim import DashedLine, NumberLine
from manim.mobject.text.numbers import Integer


Expand Down Expand Up @@ -121,3 +121,10 @@ def test_point_to_number():
np.testing.assert_array_equal(np.round(num_1, 4), np.round(expected, 4))
np.testing.assert_array_equal(np.round(num_2, 4), np.round(expected, 4))
np.testing.assert_array_equal(np.round(num_3, 4), np.round(expected, 4))


def test_start_and_end_at_same_point():
line = DashedLine(np.zeros(3), np.zeros(3))
line.put_start_and_end_on(np.zeros(3), np.array([0, 0, 0]))

np.testing.assert_array_equal(np.round(np.zeros(3), 4), np.round(line.points, 4))