Skip to content

Flake8 rule C901 is about McCabe code complexity #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Flake8 rule C901 is about McCabe code complexity #3673

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fada0c
Flake8 rule C901 is about McCabe code complexity
cclauss Apr 4, 2024
f02241d
max-complexity = 29
cclauss Apr 4, 2024
8523613
Merge branch 'main' into patch-1
cclauss Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Exclude the grpc generated code
exclude = ./manim/grpc/gen/*, __pycache__,.git,
per-file-ignores = __init__.py:F401
max-complexity = 15
max-complexity = 29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 29?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://results.pre-commit.ci/run/github/265122478/1712226727._i0WCFzjSKy7ADvbItyMbQ

max-line-length = 88
statistics = True
# Prevents some flake8-rst-docstrings errors
Expand All @@ -27,9 +27,6 @@ extend-ignore = E203, W503, D202, D212, D213, D404
# Plug-in: flake8-simplify
SIM105, SIM106, SIM119,

# Plug-in: flake8-comprehensions
C901

# Plug-in: flake8-pytest-style
PT001, PT004, PT006, PT011, PT018, PT022, PT023,

Expand Down