Skip to content

fix write_subcaption_file error when using opengl renderer #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2024
Merged

fix write_subcaption_file error when using opengl renderer #3546

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8abf17
fix write_subcaption_file error when using opengl renderer
yuan-xy Dec 23, 2023
0970e89
Update manim/scene/scene_file_writer.py
behackl Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions manim/scene/scene_file_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,6 +725,8 @@ def flush_cache_directory(self):

def write_subcaption_file(self):
"""Writes the subcaption file."""
if not config["output_file"]:
return
subcaption_file = Path(config.output_file).with_suffix(".srt")
subcaption_file.write_text(srt.compose(self.subcaptions), encoding="utf-8")
logger.info(f"Subcaption file has been written as {subcaption_file}")
Expand Down