Skip to content

Conversation

naveen521kk
Copy link
Member

@naveen521kk naveen521kk commented Jun 14, 2021

Changelog / Overview

Remove redundant warning in CLI parsing
There was a redundant warning about arguments parsing
which is never triggered.

Motivation

Cleans code that is never used.

Explanation for Changes

From #1013 there were some changes after 14fa079 which actually fixed this issue but this warning simply remained and is removed in this PR>

Documentation Reference

Checklist

  • I have read the Contributing Guidelines
  • I have written a descriptive PR title (see top of PR template for examples)
  • I have written a changelog entry for the PR or deem it unnecessary
  • My new functions/classes either have a docstring or are private
  • My new functions/classes have tests added and (optional) examples in the docs
  • My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

  • The PR title is descriptive enough
  • The PR is labeled correctly
  • The changelog entry is completed if necessary
  • Newly added functions/classes either have a docstring or are private
  • Newly added functions/classes have tests added and (optional) examples in the docs
  • Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

There was an reduntant warning about arguments parsing
which is never triggered.
@jsonvillanueva jsonvillanueva added the maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements label Jun 14, 2021
@WampyCakes WampyCakes merged commit 1574707 into ManimCommunity:main Jun 15, 2021
@naveen521kk naveen521kk deleted the remove-reduntant branch June 15, 2021 04:41
@behackl behackl changed the title Remove redundant warning in CLI parsing Removed redundant warning in CLI parsing Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants