Skip to content

OpenGL compatibility via metaclass: :class:~.TracedPath, :class:~.ParametricFunction, :class:~.Brace, :class:~.VGroup #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 31, 2021
Merged

OpenGL compatibility via metaclass: :class:~.TracedPath, :class:~.ParametricFunction, :class:~.Brace, :class:~.VGroup #1572

merged 14 commits into from
May 31, 2021

Conversation

TRoboto
Copy link
Collaborator

@TRoboto TRoboto commented May 25, 2021 •
edited by friedkeenan
Loading

Changelog / Overview

Increased OpenGL compatibility using the metaclass mechanism from #1272. TracedPath, ParametricFunction, Brace, and VGroup mobjects are now compatible with both renderers.

Documentation Reference

Testing Status

All changes were tested locally. Everything seems to work as it should.

Further Comments

PR #1324 can be closed as I don't see a need for it now.

Checklist

  • I have read the Contributing Guidelines
  • I have written a descriptive PR title (see top of PR template for examples)
  • I have written a changelog entry for the PR or deem it unnecessary
  • My new functions/classes either have a docstring or are private
  • My new functions/classes have tests added and (optional) examples in the docs
  • My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

  • The PR title is descriptive enough
  • The PR is labeled correctly
  • The changelog entry is completed if necessary
  • Newly added functions/classes either have a docstring or are private
  • Newly added functions/classes have tests added and (optional) examples in the docs
  • Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

@TRoboto TRoboto added the pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! label May 25, 2021
behackl
behackl approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, thanks for taking care of it! I just want to do some local testing, and additionally make sure that the pipeline failure isn't caused by your changes.

@behackl behackl added enhancement Additions and improvements in general maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements labels May 25, 2021
@TRoboto TRoboto mentioned this pull request May 25, 2021
Closed
12 tasks
@behackl behackl mentioned this pull request May 26, 2021
Closed
12 tasks
@TRoboto
Copy link
Collaborator Author

TRoboto commented May 27, 2021

This PR should be good now.

behackl
behackl approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a minor comment that I'd like to discuss, but otherwise this looks good to me. (Only read the code, did not test it locally.)

@TRoboto TRoboto mentioned this pull request May 27, 2021
Merged
12 tasks
behackl
behackl reviewed May 29, 2021
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional quick question. 👀

@behackl behackl mentioned this pull request May 31, 2021
Open
@behackl behackl merged commit e882b18 into ManimCommunity:master May 31, 2021
@friedkeenan friedkeenan changed the title OpenGL compatibility via metaclass: TracedPath, ParametricFunction, Brace, VGroup OpenGL compatibility via metaclass: :class:~.TracedPath, :class:~.ParametricFunction, :class:~.Brace, :class:~.VGroup` May 31, 2021
@friedkeenan friedkeenan changed the title OpenGL compatibility via metaclass: :class:~.TracedPath, :class:~.ParametricFunction, :class:~.Brace, :class:~.VGroup` OpenGL compatibility via metaclass: :class:~.TracedPath, :class:~.ParametricFunction, :class:~.Brace, :class:~.VGroup May 31, 2021
@friedkeenan friedkeenan changed the title OpenGL compatibility via metaclass: :class:~.TracedPath, :class:~.ParametricFunction, :class:~.Brace, :class:~.VGroup OpenGL compatibility via metaclass: :class:~.TracedPath, :class:~.ParametricFunction, :class:~.Brace, :class:~.VGroup` May 31, 2021
@friedkeenan friedkeenan changed the title OpenGL compatibility via metaclass: :class:~.TracedPath, :class:~.ParametricFunction, :class:~.Brace, :class:~.VGroup` OpenGL compatibility via metaclass: :class:~.TracedPath, :class:~.ParametricFunction, :class:~.Brace, :class:~.VGroup May 31, 2021
@TRoboto TRoboto deleted the opengl-metaclass branch May 31, 2021 19:52
@Darylgolden Darylgolden mentioned this pull request Jul 4, 2021
Closed
@kilacoda-old kilacoda-old mentioned this pull request Jul 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behackl behackl behackl approved these changes

Assignees

No one assigned

Labels

enhancement Additions and improvements in general maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TRoboto @behackl