-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Added two deprecation decorators #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added two deprecation decorators #1404
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor documentation and typo changes. I think this is a great feature for internal use, but if we were to release this feature as a separate package, internationalization support for the warning messages would be a big plus.
Co-authored-by: Naveen M K <[email protected]>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
Perhaps we can introduce some decorator utility commands in another PR. |
Changelog / Overview
Added two function decorators
deprecated
anddeprecated_params
as a consistent way of deprecating code.Motivation
see #1372
Closes #1372
Explanation for Changes
Have a look at the docs...
Testing Status
Further Comments
Checklist
Reviewer Checklist