-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Implementation of VideoMobject #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In this pull request, there is furthermore a file "FrameCounterVideo" that creates an example video that displays some numbers. vid.play()
self.wait(1)
vid.pause()Some thoughts what can be changed in order to make this even better:
|
|
This may be a good idea. But there is still much room for improvement. As you said, this method takes up a lot of space. If you save space and implement functions such as movement, this will be a very simple and useful operation. But at present, it does not have more advantages than using external video editing software to add video. |
|
I tend to agree with @tony031218 here. And additionally, I'm a bit weary of continuing to add new functionality before having more extensive documentation/tests. |
|
ok, then I will come back with this in a few month. |
|
@kolibril13 any progress on this PR? |
|
@safinsingh No, this is the most current version |
|
If the current plan is to "come back to this in a few months", I vote we close this until that time. By that time there will have been a bunch of other additions and the PR will essentially be entirely different. Closing for now. @kolibril13 feel free to reopen right now if you have more updates. Or please open a new PR in the future. |

This is an VideoMobject, that gives the opportunity to put videos into manim scenes.
The following thing is happening:
vid.play()in the scene file, which attaches an updater to the image canvas.