Convert vm snapshot form #9639
Open
Convert vm snapshot form #9639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilbertCherrie
force-pushed
the
convert_snapshot_tree
branch
from
ca6fa83 to
5d8cc2b
Compare
GilbertCherrie
changed the title
GilbertCherrie
force-pushed
the
convert_snapshot_tree
branch
from
1f1344f to
5941f52
Compare
Fryguy
reviewed
Sep 30, 2025
| page << "miqScrollTop();" if @flash_array.present? | ||
| page.replace("desc_content", :partial => "/vm_common/snapshots_desc", | ||
| :locals => {:selected => params[:id]}) | ||
| formatted_time = format_timezone(@snap_selected[:create_time].to_time, Time.zone, "view") |
There was a problem hiding this comment.
Should this be in the users time zone?
There was a problem hiding this comment.
Or should this be in UTC and we convert on the client side?
There was a problem hiding this comment.
This line converts it to the user's timezone in the MIQ settings, converting timezones is messy on JS and would be difficult to match the original formatting which is why I kept it on the ruby side
| page.replace("desc_content", :partial => "/vm_common/snapshots_desc", | ||
| :locals => {:selected => params[:id]}) | ||
| formatted_time = format_timezone(@snap_selected[:create_time].to_time, Time.zone, "view") | ||
| number_to_human_size(@snap_selected[:total_size], :precision => 2) |
There was a problem hiding this comment.
This line isn't doing anything on its own. Should this be used below in the formatted bytes section?
There was a problem hiding this comment.
I just copied the original code for this part. Is the original code wrong here?
= number_to_human_size(selected_id[:total_size], :precision => 2)
= _("(%{number} bytes)") % {:number => number_with_delimiter(selected_id[:total_size], :delimiter => ",", :separator => ".")}
elsamaryv
reviewed
Oct 1, 2025
elsamaryv
reviewed
Oct 1, 2025
app/javascript/components/vm-snapshot-tree-select/snapshot-tree.jsx
Outdated
Show resolved
Hide resolved
elsamaryv
reviewed
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9518. This pr converts the vm snapshot tree page from HAML to React.
Before:
After:
