[WIP] Add columns for payload valid and error for workflows #9632
Conversation
|
@agrare I'm not sure what this pr is for, can you include screenshots of where in the UI you want these icons |
|
@agrare I don't think we should show the error on the list view page - the valid/invalid is sufficient and they can click through for the error. @GilbertCherrie The new Valid column. Ideally it show show a check or x like we do for compliant on vms. |
| - repository | ||
| - created_at | ||
| - updated_at | ||
| - payload_valid |
There was a problem hiding this comment.
Presentation wise I think put these before the dates.
Yeah I was thinking we could do a tooltip over the invalid X if possible, if not I can drop it and just show on the details page |
agrare
force-pushed
the
add_payload_valid_payload_error_columns
branch
from
02f0b33 to
a9c8ad5
Compare
|
@agrare I updated this pr with the icons for the table |
|
Awesome thanks @GilbertCherrie , do you know if there is a way to show just the icon and not True/False after it? |
I'm not sure but I can check |
This should really be a green check or a red X but I'm not sure how best to do that, @GilbertCherrie ? One of the col_formats maybe?