Skip to content

Conversation

GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Sep 17, 2025

This pr fixes an issue with the tagging form. Also, this pr removes the checkboxes from the tagging form table.

Before:
Select multiple service catalog items then go to the Policy / Edit Tags form. Click cancel on the form. Then when selecting a single catalog item and going to the Edit Tags form from the summary screen still shows the multiple items being tagged on the form.
Screenshot 2025-09-17 at 12 01 12 PM

After:
Only the selected service catalog item from the summary screen will show up on the tagging form.
Screenshot 2025-09-17 at 12 02 53 PM

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner September 17, 2025 15:53
@GilbertCherrie GilbertCherrie force-pushed the fix_single_tag branch 2 times, most recently from 201f0e9 to c42f2d1 Compare September 17, 2025 15:54
@GilbertCherrie GilbertCherrie requested review from Fryguy and elsamaryv and removed request for a team, Fryguy and elsamaryv September 17, 2025 16:03
@GilbertCherrie GilbertCherrie requested review from a team and elsamaryv September 17, 2025 16:22
@GilbertCherrie GilbertCherrie force-pushed the fix_single_tag branch 4 times, most recently from 0233b99 to 6721a36 Compare September 17, 2025 17:58
@Fryguy
Copy link
Member

Fryguy commented Sep 17, 2025

@elsamaryv Please review.

@GilbertCherrie GilbertCherrie force-pushed the fix_single_tag branch 2 times, most recently from 5821d47 to 867a78e Compare September 18, 2025 14:53
@GilbertCherrie
Copy link
Member Author

GilbertCherrie commented Sep 24, 2025

@elsamaryv please review and test again when you have time

Copy link
Contributor

@elsamaryv elsamaryv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fryguy Fryguy merged commit b5911c2 into ManageIQ:master Oct 8, 2025
19 checks passed
@GilbertCherrie GilbertCherrie deleted the fix_single_tag branch October 8, 2025 19:29
@Fryguy
Copy link
Member

Fryguy commented Oct 9, 2025

Backported to spassky in commit d622432.

commit d622432f495c19119ee4f93a2eb9f2405d50bae6
Author: Jason Frey <[email protected]>
Date:   Wed Oct 8 15:29:12 2025 -0400

    Merge pull request #9622 from GilbertCherrie/fix_single_tag
    
    Fix single tag page bug
    
    (cherry picked from commit b5911c2d2134346f024360019bdbf264df703eb1)

Fryguy added a commit that referenced this pull request Oct 9, 2025
Fix single tag page bug

(cherry picked from commit b5911c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants