-
Notifications
You must be signed in to change notification settings - Fork 73
Fix automation array values #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Need a ui fix for this: ManageIQ/manageiq-ui-classic@3cdd007 |
kbrock
reviewed
May 30, 2024
e83b6fe to
5d6b6ef
Compare
5d6b6ef to
a81de65
Compare
Member
|
Checked commits GilbertCherrie/manageiq-automation_engine@a81de65~...c54ce45 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_object.rb
|
Fryguy
approved these changes
Jun 28, 2024
Member
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Jun 28, 2024
Fix automation array values (cherry picked from commit 7707684)
This was referenced Jul 3, 2024
Fryguy
added a commit
that referenced
this pull request
Sep 6, 2024
…rays" This reverts commit f74123e.
Member
|
Reverted backport to |
Member
|
Reverted via 1ef49fb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed automation array values for multi select drop downs in Order Service Forms.
When ordering from a Service Catalog for an Ansible Playbook Catalog Item there is a bug with multi-select dropdown values not being correctly sent to the Ansible Playbook.
An example order service form with a multi-select dropdown:

Before:

When viewing the Ansible Playbook output in the Services / My Services Screen for the Service you order will look like this.
test1is the multi-select dropdown value and it outputs "VARIABLE IS NOT DEFINED!".test2is just a single select dropdown used for reference.This is due to the field being with "Array::" on its key value causing the Ansible Playbook output to not be able to find that variable. When the "Array::" tag is removed from the key it then displays the Array as a String with

\u001fseparating the Array items.After:

By removing the "Array::" tag from the variable key as well as converting the value being sent to the Ansible Playbook from a String to an Array we receive the Array in the Playbook and see it on the Playbook output correctly. This allows us to send Arrays to the Ansible Playbook and view it correctly on the output screen as individual items instead of as a String.