14 physician note examples #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_*** methods typesystem.py
NO Assumption is made of the user as to which is preferred.
moved static methods to functions
mikix
approved these changes
Sep 26, 2022
Comment on lines
+4
to
+5
| from .typesystem import CtakesJSON, MatchText, Polarity, Span | ||
| from .typesystem import UmlsTypeMention, UmlsConcept |
There was a problem hiding this comment.
Convenience imports, so consumers don't have to use ctakesclient.typesystem? I kind of like the idea of having one canonical import location though -- if we do this, how do you feel about dropping the from . import typesystem then?
Comment on lines
+41
to
+42
| # import re | ||
| # return re.sub(r'[^\u1F600-\u1F64F ]|[^\u1F300-\u1F5FF ]', " ", sentence) |
There was a problem hiding this comment.
Can delete these comment lines.
|
As we discussed out-of-band, I have moved the bulk of this PR to a separate repo, just for clinical note samples: https://github.com/Machine-Learning-for-Medical-Language/ctakes-examples I'd suggest we drop this PR in favor of releasing that (and/or we salvage some of the code cleanups in this branch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
physician note examples with term frequency
test-integration files refactored
static methods are now typesystem.helper_function*