Skip to content
This repository was archived by the owner on Feb 15, 2023. It is now read-only.

MAINT: Timestamp nightly wheel filenames #77

Closed
tylerjereddy opened this issue May 15, 2020 · 3 comments
Closed

MAINT: Timestamp nightly wheel filenames #77

tylerjereddy opened this issue May 15, 2020 · 3 comments

Comments

@tylerjereddy
Copy link
Collaborator

Based on discussion with @mattip in #74, downstream projects using pip to pull in our wheels from the nightly (weekly) anaconda.org repo appear to need dates stamped right into filenames, presumably because pip is not scraping timestamp metadata directly from the uploaded files.

So it just kind of arbitrarily sorts by hash alphanumerically, which is bad.

While I'd prefer if there were a simple pip install flag of some sort that "just worked" for pulling in the latest based on metadata, I'll open this issue to try to get done soon-ish.

At least for us, we only need to worry about Travis--we haven't done nightlies for Windows/Appveyor in recent history AFAIK.

@bashtage
Copy link

I don't think you have to timestamp. You could also use the structure

scipy-1.5.0.dev0+NUMBER_OF_COMMITS_AFTER_dev0.g6fd3052-cp38-cp38-macosx_10_9_x86_64.whl

tylerjereddy added a commit to tylerjereddy/scipy-wheels that referenced this issue May 30, 2020
* as outlined in MacPythongh-77, downstream projects will have
a hard time automatically downloading our most recently
"nightly" (actually weekly) wheel uploads if we don't
add a timestamp of sorts

* this patch attempts to "borrow" the machinery added by
Matti in `https://github.com/MacPython/numpy-wheels/pull/84`
for this purpose
@tylerjereddy
Copy link
Collaborator Author

tylerjereddy commented May 31, 2020

Following the merging of the cross-linked PR above--I should check mid-week after the Tuesday "nightly" upload to see if the wheels are properly named for downstream pip download purposes.

@tylerjereddy
Copy link
Collaborator Author

The timestamping appears to have worked as intended for the weekly uploads last Tuesday: https://anaconda.org/scipy-wheels-nightly/scipy/files

I've also manually purged the older weekly wheel uploads, with incorrect file naming, to prevent interference with automated downloads from downstream projects using pip in CI, etc.

So, I'll close this issue. @bashtage -- feel free to open an issue/ping me if statsmodels or other projects are having issues with our weekly wheels.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants